Code review comment for lp:~widelands-dev/widelands-website/anti_spam_3

Revision history for this message
kaputtnik (franku) wrote :

> Instead of sending an email immediately and for each post, how about adding a
> django command that sends an email if there are hidden posts every night. That
> way even us admins would not be drowned by the SPAM and we could delete
> accordingly.

Yes that would be good if all hidden posts are really spam. In case of no Spam the post should be unhided as soon as possible imho. If one is posting something in the morning which is marked as spam accidentally, he has to wait until the next morning to unhide it with your suggestion. Maybe this is a rare use case, but we should not forget the possibility of accidentally marked spam.

As an alternative we could use another group of email recipients. E.g. there is a group 'forum_admin' which may could be used.

>
> one suggestion in the code, otherwise code lgtm.

Thanks. The code is similar to the 'legal_notice' email so it would make sense to have a global method. The method should be e.g. in wl_utils.py and accept various parameters. But i guess this is not what you meant :-)

I add a comment to the code and merge it tomorrow if no one complains.

« Back to merge proposal