Merge lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral into lp:ubuntu/oneiric/python-oauth

Proposed by Mat Scales
Status: Work in progress
Proposed branch: lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Merge into: lp:ubuntu/oneiric/python-oauth
Diff against target: 53 lines (+11/-6)
3 files modified
debian/changelog (+7/-0)
debian/control (+3/-5)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Disapprove
Ubuntu branches Pending
Review via email: mp+65686@code.launchpad.net

Description of the change

Removed the dependency on pycentral, as described at https://wiki.ubuntu.com/BarryWarsaw/PythonHelpers

To post a comment you must log in.
8. By Mat Scales

Incorrect release version

9. By Mat Scales

Updated the maintainer

Revision history for this message
Stefano Rivera (stefanor) wrote :

LGTM (as a non-core-dev)

To the sponsor: be aware that there's a newer version of this package in Debian, which has ported to dh_python2 already.

This should probably be merged (and that'll give version number hassles)

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Mat, thanks very much for your contribution to Ubuntu! As Stefano mentions in the above comment, Debian has a newer version of python-oauth that gives us a new upstream version and switches to dh_python2. Now that Oneiric alpha 2 has been released, this newer version of python-oauth has been sync'd from Debian. We appreciate your help anyway!

Also please let me know if you'd like to work on the conversion for any of the other outstanding packages in bug 788514. You can reach me on #ubuntu-pyjam or #ubuntu-devel on freenode, nick 'barry'.

review: Disapprove

Unmerged revisions

9. By Mat Scales

Updated the maintainer

8. By Mat Scales

Incorrect release version

7. By Mat Scales

debian/rules, debian/control: Transition to dh_python2 from pycentral
(LP: #788514)

6. By James Westby

Various fixes from Rodney, thanks.

* oauth/oauth.py: Fix typo and argument handling creating invalid
  OAuthRequests with from_consumer_and_token staticmethod().
  (LP: #435994, http://code.google.com/p/oauth/issues/detail?id=117)
* oauth/oauth.py: Fix HMAC-SHA1 verification to follow OAuth Core 1.0 spec
  (LP: #435992, http://code.google.com/p/oauth/issues/detail?id=125)
* New upsream snapshot, includes partial fix for issue 117, and fixes
  an error being raised when no verifier is sent to the server

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2009-09-24 18:14:58 +0000
+++ debian/changelog 2011-06-23 16:06:28 +0000
@@ -1,3 +1,10 @@
1python-oauth (1.0a~svn1124-0ubuntu3) oneiric; urgency=low
2
3 * debian/rules, debian/control: Transition to dh_python2 from pycentral
4 (LP: #788514)
5
6 -- Mat Scales <mat@wibbly.org.uk> Thu, 23 Jun 2011 16:33:51 +0100
7
1python-oauth (1.0a~svn1124-0ubuntu2) karmic; urgency=low8python-oauth (1.0a~svn1124-0ubuntu2) karmic; urgency=low
29
3 * oauth/oauth.py: Fix typo and argument handling creating invalid10 * oauth/oauth.py: Fix typo and argument handling creating invalid
411
=== modified file 'debian/control'
--- debian/control 2009-06-15 15:19:57 +0000
+++ debian/control 2011-06-23 16:06:28 +0000
@@ -1,18 +1,16 @@
1Source: python-oauth1Source: python-oauth
2Section: python2Section: python
3Priority: optional3Priority: optional
4Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: James Westby <james.westby@ubuntu.com>5XSBC-Original-Maintainer: James Westby <james.westby@ubuntu.com>
6Build-Depends: debhelper (>= 6), python, python-setuptools6Build-Depends: debhelper (>= 6), python (>=2.6.6-3~), python-setuptools
7Build-Depends-Indep: python-central (>= 0.6.0)
8Standards-Version: 3.8.17Standards-Version: 3.8.1
9Homepage: http://code.google.com/p/oauth/8Homepage: http://code.google.com/p/oauth/
10XS-Python-Version: >=2.49X-Python-Version: >= 2.6
1110
12Package: python-oauth11Package: python-oauth
13Architecture: all12Architecture: all
14Depends: ${misc:Depends}, ${python:Depends}13Depends: ${misc:Depends}, ${python:Depends}
15XB-Python-Version: ${python:Versions}
16Description: implementation of the OAuth protocol14Description: implementation of the OAuth protocol
17 This libarary implements a Python version of the OAuth protocol15 This libarary implements a Python version of the OAuth protocol
18 for authentication. It can be used to implement both the client16 for authentication. It can be used to implement both the client
1917
=== modified file 'debian/rules'
--- debian/rules 2009-07-09 15:51:48 +0000
+++ debian/rules 2011-06-23 16:06:28 +0000
@@ -29,7 +29,7 @@
29 dh_installchangelogs 29 dh_installchangelogs
30 dh_installdocs30 dh_installdocs
31 dh_installexamples31 dh_installexamples
32 dh_pycentral32 dh_python2
33 dh_link33 dh_link
34 dh_strip34 dh_strip
35 dh_compress35 dh_compress

Subscribers

People subscribed via source and target branches

to all changes: