Merge lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral into lp:ubuntu/oneiric/python-oauth

Proposed by Mat Scales
Status: Work in progress
Proposed branch: lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Merge into: lp:ubuntu/oneiric/python-oauth
Diff against target: 53 lines (+11/-6)
3 files modified
debian/changelog (+7/-0)
debian/control (+3/-5)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~wibblymat/ubuntu/oneiric/python-oauth/replace-pycentral
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Disapprove
Ubuntu branches Pending
Review via email: mp+65686@code.launchpad.net

Description of the change

Removed the dependency on pycentral, as described at https://wiki.ubuntu.com/BarryWarsaw/PythonHelpers

To post a comment you must log in.
8. By Mat Scales on 2011-06-23

Incorrect release version

9. By Mat Scales on 2011-06-23

Updated the maintainer

Revision history for this message
Stefano Rivera (stefanor) wrote :

LGTM (as a non-core-dev)

To the sponsor: be aware that there's a newer version of this package in Debian, which has ported to dh_python2 already.

This should probably be merged (and that'll give version number hassles)

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Mat, thanks very much for your contribution to Ubuntu! As Stefano mentions in the above comment, Debian has a newer version of python-oauth that gives us a new upstream version and switches to dh_python2. Now that Oneiric alpha 2 has been released, this newer version of python-oauth has been sync'd from Debian. We appreciate your help anyway!

Also please let me know if you'd like to work on the conversion for any of the other outstanding packages in bug 788514. You can reach me on #ubuntu-pyjam or #ubuntu-devel on freenode, nick 'barry'.

review: Disapprove

Unmerged revisions

9. By Mat Scales on 2011-06-23

Updated the maintainer

8. By Mat Scales on 2011-06-23

Incorrect release version

7. By Mat Scales on 2011-06-23

debian/rules, debian/control: Transition to dh_python2 from pycentral
(LP: #788514)

6. By James Westby on 2009-09-24

Various fixes from Rodney, thanks.

* oauth/oauth.py: Fix typo and argument handling creating invalid
  OAuthRequests with from_consumer_and_token staticmethod().
  (LP: #435994, http://code.google.com/p/oauth/issues/detail?id=117)
* oauth/oauth.py: Fix HMAC-SHA1 verification to follow OAuth Core 1.0 spec
  (LP: #435992, http://code.google.com/p/oauth/issues/detail?id=125)
* New upsream snapshot, includes partial fix for issue 117, and fixes
  an error being raised when no verifier is sent to the server

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-09-24 18:14:58 +0000
3+++ debian/changelog 2011-06-23 16:06:28 +0000
4@@ -1,3 +1,10 @@
5+python-oauth (1.0a~svn1124-0ubuntu3) oneiric; urgency=low
6+
7+ * debian/rules, debian/control: Transition to dh_python2 from pycentral
8+ (LP: #788514)
9+
10+ -- Mat Scales <mat@wibbly.org.uk> Thu, 23 Jun 2011 16:33:51 +0100
11+
12 python-oauth (1.0a~svn1124-0ubuntu2) karmic; urgency=low
13
14 * oauth/oauth.py: Fix typo and argument handling creating invalid
15
16=== modified file 'debian/control'
17--- debian/control 2009-06-15 15:19:57 +0000
18+++ debian/control 2011-06-23 16:06:28 +0000
19@@ -1,18 +1,16 @@
20 Source: python-oauth
21 Section: python
22 Priority: optional
23-Maintainer: Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25 XSBC-Original-Maintainer: James Westby <james.westby@ubuntu.com>
26-Build-Depends: debhelper (>= 6), python, python-setuptools
27-Build-Depends-Indep: python-central (>= 0.6.0)
28+Build-Depends: debhelper (>= 6), python (>=2.6.6-3~), python-setuptools
29 Standards-Version: 3.8.1
30 Homepage: http://code.google.com/p/oauth/
31-XS-Python-Version: >=2.4
32+X-Python-Version: >= 2.6
33
34 Package: python-oauth
35 Architecture: all
36 Depends: ${misc:Depends}, ${python:Depends}
37-XB-Python-Version: ${python:Versions}
38 Description: implementation of the OAuth protocol
39 This libarary implements a Python version of the OAuth protocol
40 for authentication. It can be used to implement both the client
41
42=== modified file 'debian/rules'
43--- debian/rules 2009-07-09 15:51:48 +0000
44+++ debian/rules 2011-06-23 16:06:28 +0000
45@@ -29,7 +29,7 @@
46 dh_installchangelogs
47 dh_installdocs
48 dh_installexamples
49- dh_pycentral
50+ dh_python2
51 dh_link
52 dh_strip
53 dh_compress

Subscribers

People subscribed via source and target branches

to all changes: