Code review comment for lp:~whosdaz/ubuntu-html5-theme/fixnav

David Barth (dbarth) wrote :

Hi Matthew,

The content feels correct. But the icons are broken when I test them. The <img links to pre-installed image files, which are actually not installed.

It would be better to have relative URLs to the theme directory / branch. Moving foward, the theme is not pre-installed on the system anymore but bundled into an application (click) package.

You can check the "ubuntu-html5-theme" tool at the root of the branch. It is used by app developers to download and install the theme directly in their application directory.

review: Needs Fixing

« Back to merge proposal