Merge lp:~whobers/ubuntu-manual-tests/anythinh into lp:ubuntu-manual-tests

Proposed by Willem Hobers
Status: Merged
Merged at revision: 380
Proposed branch: lp:~whobers/ubuntu-manual-tests/anythinh
Merge into: lp:ubuntu-manual-tests
Diff against target: 25 lines (+2/-2)
2 files modified
testcases/packages/1587_Gigolo (+1/-1)
testcases/packages/Xfce/1563_Xfce4 Workspace Settings (+1/-1)
To merge this branch: bzr merge lp:~whobers/ubuntu-manual-tests/anythinh
Reviewer Review Type Date Requested Status
Kev Bowring (community) Approve
Review via email: mp+346422@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kev Bowring (flocculant) wrote :

Small extra change in 1587 then it'll be good to merge.
Thanks Willem

review: Needs Fixing
Revision history for this message
Willem Hobers (whobers) wrote :

Most certainly. I had noticed the "accordingly" but not being a native
speaker I thought that I was being over-correcting with my
school-English in this case.

Will fix.

Op 21-05-18 om 21:53 schreef Kev Bowring:
> Given we're typos fixing - can we change accordingly to according - then I can merge.

382. By Willem Hobers

changed type to solve LP1772142

Revision history for this message
Willem Hobers (whobers) wrote :

Have changed "accordingly" to according.
Could you have a look again, please?

Revision history for this message
Willem Hobers (whobers) wrote :

Have done the change; committed and pushed.

Process-wise I'm not sure now: do I need to re-propose the merge?

W

Op 21-05-18 om 21:53 schreef Kev Bowring:
> Given we're typos fixing - can we change accordingly to according - then I can merge.

Revision history for this message
Kev Bowring (flocculant) wrote :

Thanks Willem

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testcases/packages/1587_Gigolo'
2--- testcases/packages/1587_Gigolo 2015-10-25 10:37:26 +0000
3+++ testcases/packages/1587_Gigolo 2018-05-22 07:35:12 +0000
4@@ -27,7 +27,7 @@
5 <dt>Point your mouse pointer to the 'Interface' tab and click it</dt>
6 <dd>Interface tab displays</dd>
7 <dt>Tick/Untick the options given</dt>
8- <dd>Gigolo's GUI definitions and display the of auto-connect error messages change accordingly to the preferences set</dd>
9+ <dd>Gigolo's GUI definitions and display of the auto-connect error messages change according to the preferences set</dd>
10 <dt>Point your mouse pointer to the 'Toolbar' tab and click it</dt>
11 <dd>Toolbar tab displays</dd>
12 <dt>Untick the 'Show toolbar' option</dt>
13
14=== modified file 'testcases/packages/Xfce/1563_Xfce4 Workspace Settings'
15--- testcases/packages/Xfce/1563_Xfce4 Workspace Settings 2014-11-07 23:06:51 +0000
16+++ testcases/packages/Xfce/1563_Xfce4 Workspace Settings 2018-05-22 07:35:12 +0000
17@@ -8,7 +8,7 @@
18 <dd>You are now able to type a name for the workspace</dd>
19 <dt>Type a name for the workspace, then press Enter</dt>
20 <dd>The workspace name changes in the list</dd>
21- <dt>Hover the cursor over the indictor icon of the workspace you just named</dt>
22+ <dt>Hover the cursor over the indicator icon of the workspace you just named</dt>
23 <dd>The test "Click to switch to [Workspace Name]" appears</dd>
24 <dt>Press "Help"</dt>
25 <dd>This takes you to an online manual</dd>

Subscribers

People subscribed via source and target branches