Merge lp:~whitmo/charms/trusty/cloudfoundry/1.24-fixes into lp:~cf-charmers/charms/trusty/cloudfoundry/trunk

Proposed by Whit Morriss
Status: Needs review
Proposed branch: lp:~whitmo/charms/trusty/cloudfoundry/1.24-fixes
Merge into: lp:~cf-charmers/charms/trusty/cloudfoundry/trunk
Diff against target: 106 lines (+27/-24)
2 files modified
README.rst (+26/-23)
cloudfoundry/utils.py (+1/-1)
To merge this branch: bzr merge lp:~whitmo/charms/trusty/cloudfoundry/1.24-fixes
Reviewer Review Type Date Requested Status
Benjamin Saller (community) Approve
Review via email: mp+264581@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Whit Morriss (whitmo) wrote :

Minor fixes to get cf running with juju 1.24 & some more aggressive linewrapping for the Readme.

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM, might want to add a comment that this now needs 1.24+ to deploy (after that status format change).

review: Approve

Unmerged revisions

170. By Whit Morriss

format readme, update jujuclient and raindance deps, 1.24 compat for utils.py

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.rst'
2--- README.rst 2014-11-12 03:55:51 +0000
3+++ README.rst 2015-07-13 14:46:01 +0000
4@@ -14,23 +14,25 @@
5
6 A juju charm to deploy and manage a Cloud Foundry deployment.
7
8-If you are unfamiliar with CloudFoundry we suggest referring to their documentation.
9+If you are unfamiliar with CloudFoundry we suggest referring to their
10+documentation.
11
12 http://docs.cloudfoundry.org/
13
14 Documenting CF is beyond the scope of this project. However, once deployed, using the
15 system is a normal CF experience as described in the above docs.
16
17-We provide a set of helper scripts (in bash) which can be used to assist in the deployment and
18-management of CF.
19+We provide a set of helper scripts (in bash) which can be used to
20+assist in the deployment and management of CF.
21
22
23 Deployment
24 ----------
25
26-It is recommended that you obtain a local copy of the charm, as it will give you access
27-to helper scripts which can auto-configure the system. This is largely because of the way
28-an orchestrator charm needs admin access to the running deployment.
29+It is recommended that you obtain a local copy of the charm, as it
30+will give you access to helper scripts which can auto-configure the
31+system. This is largely because of the way an orchestrator charm needs
32+admin access to the running deployment.
33
34 To obtain the charm:
35
36@@ -41,19 +43,20 @@
37
38 ./cfdeploy <cf_admin_password>
39
40-This will gather the necessary Juju admin credentials and boot up the bundle
41-orchestrator which will setup and manage a CF deployment using Juju. The command
42-will block until the deployment is fully up and running. It also will create a
43-CF "admin" user with the given password, leaving you logged in and ready to push
44-a CF app. Note that while this can take quite some time, the whole process is
45-automated.
46-
47-If you don't have the cf command line client the latest one will be installed
48-from a .deb package to your local system as part of cfdeploy.
49-
50-Once the deploy completes, you can push apps. A sample application we recommend
51-to become familiar with the system is GitHub High Score website. This can be
52-pushed with the following:
53+This will gather the necessary Juju admin credentials and boot up the
54+bundle orchestrator which will setup and manage a CF deployment using
55+Juju. The command will block until the deployment is fully up and
56+running. It also will create a CF "admin" user with the given
57+password, leaving you logged in and ready to push a CF app. Note that
58+while this can take quite some time, the whole process is automated.
59+
60+If you don't have the cf command line client the latest one will be
61+installed from a .deb package to your local system as part of
62+cfdeploy.
63+
64+Once the deploy completes, you can push apps. A sample application we
65+recommend to become familiar with the system is GitHub High Score
66+website. This can be pushed with the following:
67
68 git clone https://github.com/bcsaller/github-high-scores
69 cd github-high-scores
70@@ -75,10 +78,10 @@
71
72 You can then use the CF admin user credentials to log in.
73
74-Note that, currently, once the Admin UI is deployed, you must manually remove
75-it if you change the value of the `admin_ui` option, but that changing the
76-option is required to prevent the Admin UI from potentially being re-deployed
77-after being manually removed.
78+Note that, currently, once the Admin UI is deployed, you must manually
79+remove it if you change the value of the `admin_ui` option, but that
80+changing the option is required to prevent the Admin UI from
81+potentially being re-deployed after being manually removed.
82
83
84 Development
85
86=== modified file 'cloudfoundry/utils.py'
87--- cloudfoundry/utils.py 2015-01-16 22:06:05 +0000
88+++ cloudfoundry/utils.py 2015-07-13 14:46:01 +0000
89@@ -390,7 +390,7 @@
90 return False
91 sdata = status['Services']['cloudfoundry']
92 for unit in sdata['Units'].values():
93- if unit['Agent']['Status'] not in ['installed', 'started']:
94+ if unit['AgentState'] not in ['installed', 'started']:
95 return False
96 return True
97
98
99=== removed file 'wheelhouse/jujuclient-0.18.4-py2-none-any.whl'
100Binary files wheelhouse/jujuclient-0.18.4-py2-none-any.whl 2014-10-07 16:01:59 +0000 and wheelhouse/jujuclient-0.18.4-py2-none-any.whl 1970-01-01 00:00:00 +0000 differ
101=== added file 'wheelhouse/jujuclient-0.50.1-py2-none-any.whl'
102Binary files wheelhouse/jujuclient-0.50.1-py2-none-any.whl 1970-01-01 00:00:00 +0000 and wheelhouse/jujuclient-0.50.1-py2-none-any.whl 2015-07-13 14:46:01 +0000 differ
103=== removed file 'wheelhouse/raindance-0.3dev_r0-py2-none-any.whl'
104Binary files wheelhouse/raindance-0.3dev_r0-py2-none-any.whl 2014-11-06 18:44:09 +0000 and wheelhouse/raindance-0.3dev_r0-py2-none-any.whl 1970-01-01 00:00:00 +0000 differ
105=== added file 'wheelhouse/raindance-0.5-py2-none-any.whl'
106Binary files wheelhouse/raindance-0.5-py2-none-any.whl 1970-01-01 00:00:00 +0000 and wheelhouse/raindance-0.5-py2-none-any.whl 2015-07-13 14:46:01 +0000 differ

Subscribers

People subscribed via source and target branches