Merge lp:~wgrant/turnip/no-buildout into lp:turnip
| Status: | Merged |
|---|---|
| Merged at revision: | 104 |
| Proposed branch: | lp:~wgrant/turnip/no-buildout |
| Merge into: | lp:turnip |
| Diff against target: |
686 lines (+67/-528) 10 files modified
Makefile (+24/-96) _bootstrap/COPYRIGHT.txt (+0/-9) _bootstrap/LICENSE.txt (+0/-54) _bootstrap/bootstrap.py (+0/-277) buildout.cfg (+0/-33) pygit2-requirements.txt (+3/-0) requirements.txt (+6/-19) setup.py (+20/-7) test-requirements.txt (+14/-0) versions.cfg (+0/-33) |
| To merge this branch: | bzr merge lp:~wgrant/turnip/no-buildout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson | 2015-03-12 | Approve on 2015-03-12 | |
|
Review via email:
|
|||
Commit Message
Drop buildout support, make things more usable with pip, and fix "setup.py test".
Description of the Change
Maintaining infrastructure for both buildout and pip was silly, and the Python world clearly favours pip, so let's drop buildout support and make development without it more sensible.
The pip requirements.txt still exists, and now includes pygit2 bits. test-requiremen
But normal development should probably not use requirements.txt. I've added the relevant sdists to lp:lp-source-dependencies (assumed to be checked out in the download-cache subdirectory of your source tree), so one can now do an offline installation like this:
~/src/turnip$ # Prevent setup_requires like pbr from hitting PyPI.
~/src/turnip$ cat ~/.pydistutils.cfg << EOF
[easy_install]
allow_hosts = ''
find_links = file://
EOF
~/src/turnip$ virtualenv --no-site-packages env
~/src/turnip$ env/bin/pip install --no-index --find-
~/src/turnip$ env/bin/python setup.py test
It also works with --system-
- 113. By William Grant on 2015-03-12
-
Split out pygit2 deps so the charm can use a PPA package rather than shipping libgit2-dev everywhere.

As discussed on IRC, we need to pull cffi, pycparser, and pygit2 out of requirements.txt (and possibly into a separate requirements file) to avoid making charm deployment depend on having a matching version of libgit2-dev on the deployment system. Other than that this seems fine.