Merge lp:~wgrant/launchpad/webhook-event-types into lp:launchpad
Proposed by
William Grant
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17687 | ||||
Proposed branch: | lp:~wgrant/launchpad/webhook-event-types | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
334 lines (+96/-20) 7 files modified
lib/lp/services/webhooks/browser.py (+7/-4) lib/lp/services/webhooks/configure.zcml (+9/-0) lib/lp/services/webhooks/interfaces.py (+18/-3) lib/lp/services/webhooks/model.py (+2/-0) lib/lp/services/webhooks/tests/test_browser.py (+6/-5) lib/lp/services/webhooks/tests/test_model.py (+19/-0) lib/lp/services/webhooks/tests/test_webservice.py (+35/-8) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/webhook-event-types | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+267470@code.launchpad.net |
Commit message
Improve Webhook.event_types widget and value checking.
Description of the change
Improve Webhook.event_types widget and value checking.
Rather than a weird Zopey text list widget, there's now a set of checkboxes for each known event type. I've eschewed a normal enum due to the non-DB-column and potentially fluid nature of event types; a custom vocabulary is easy and makes migration easier when we change things later.
To post a comment you must log in.