Merge lp:~wgrant/launchpad/turn-off-parallel-a-f into lp:launchpad

Proposed by William Grant
Status: Merged
Approved by: William Grant
Approved revision: no longer in the source branch.
Merged at revision: 12529
Proposed branch: lp:~wgrant/launchpad/turn-off-parallel-a-f
Merge into: lp:launchpad
Diff against target: 24 lines (+6/-8)
1 file modified
lib/lp/archivepublisher/model/ftparchive.py (+6/-8)
To merge this branch: bzr merge lp:~wgrant/launchpad/turn-off-parallel-a-f
Reviewer Review Type Date Requested Status
Abel Deuring (community) code Approve
Review via email: mp+52185@code.launchpad.net

Commit message

[r=adeuring][bug=729003] Turn off parallel apt-ftparchive; --arch doesn't actually help us at all.

Description of the change

Deeper QA of the recent parallel apt-ftparchive changes revealed that --arch doesn't actually restrict the work that a-f does, so we ended up just doing the same work several times in parallel.

This branch reverts a-f to a single run, until we can fix it properly next release.

To post a comment you must log in.
Revision history for this message
Abel Deuring (adeuring) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/archivepublisher/model/ftparchive.py'
2--- lib/lp/archivepublisher/model/ftparchive.py 2011-02-25 11:54:05 +0000
3+++ lib/lp/archivepublisher/model/ftparchive.py 2011-03-04 11:42:42 +0000
4@@ -167,14 +167,12 @@
5 spawner = CommandSpawner()
6
7 returncodes = {}
8- for arch_tag in self._getArchitectureTags().union(set(["source"])):
9- completion_handler = ReturnCodeReceiver()
10- returncodes[arch_tag] = completion_handler
11- command = base_command + ["--arch", arch_tag]
12- spawner.start(
13- command, stdout_handler=stdout_handler,
14- stderr_handler=stderr_handler,
15- completion_handler=completion_handler)
16+ completion_handler = ReturnCodeReceiver()
17+ returncodes['all'] = completion_handler
18+ spawner.start(
19+ base_command, stdout_handler=stdout_handler,
20+ stderr_handler=stderr_handler,
21+ completion_handler=completion_handler)
22
23 spawner.complete()
24 stdout_handler.finalize()