Merge lp:~wgrant/launchpad/sharing-icon-fix into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16576 |
Proposed branch: | lp:~wgrant/launchpad/sharing-icon-fix |
Merge into: | lp:launchpad |
Diff against target: |
65 lines (+19/-5) 3 files modified
Makefile (+2/-2) lib/lp/registry/javascript/sharing/granteetable.js (+2/-3) lib/lp/registry/javascript/sharing/tests/test_granteetable.js (+15/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/sharing-icon-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+159751@code.launchpad.net |
Commit message
Fix +sharing permission picker creation to unhide the right edit icon.
Description of the change
The grantee table JS on +sharing was always unhiding the first edit icon in each row, even when activating a permission other than the first. Fix it to always show the right one.
I also fixed jsbuild to rebuild the LP JS without having to clean first.
To post a comment you must log in.