Merge lp:~wgrant/launchpad/rargh-foreign-keys into lp:launchpad/db-devel

[William Grant]

Add DB patch 2209-11-2 to drop foreign keys that prevent that tables dropped by 11-1 from actually being dropped.

I am a moron. upgrade.py drops todrop tables in undefined order, so I need to drop foreign keys between dropped tables or the post-patching replication fixup breaks. I've confirmed on a local replicated setup that this fixes both the staging (11-1 already applied but dropping failed) and production (neither already applied) cases.

[Robert Collins (lifeless)]

heh, doit.

[Stuart Bishop (stub)]

I'd blame the convoluted and obtuse system rather than the lack of foresight. And the blase db reviewer :-)

review: Approve (db)

=== added file 'database/schema/patch-2209-11-2.sql'
--- database/schema/patch-2209-11-2.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-11-2.sql	2012-02-21 23:24:23 +0000
@@ -0,0 +1,15 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+-- Drop foreign keys within the old access policy model so slony can
+-- drop them out of order.
+ALTER TABLE todrop.AccessPolicyArtifact
+    DROP CONSTRAINT accesspolicyartifact_policy_fkey; 
+ALTER TABLE todrop.AccessPolicyGrant
+    DROP CONSTRAINT accesspolicygrant_artifact_fkey; 
+ALTER TABLE todrop.AccessPolicyGrant
+    DROP CONSTRAINT accesspolicygrant_policy_fkey; 
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 11, 2);