Merge lp:~wgrant/launchpad/involvement-config-validity into lp:launchpad

[William Grant]

Fix the involvement portlet's config section to not abuse HTML form elements and be slightly prettier.

This branch makes the involvement portlet slightly more HTML-compliant and less broken when rendered as HTML5.

I replaced the table progress bar with a div > img. This ends up full width, looking a bit more sensible. It also doesn't suffer spacing issues when rendered as HTML5.

It was also rather broken in IE due to <legend> abuse. activate_collapsibles was originally designed for expanding fieldsets in forms, so it basically expects to be run on a fieldset.collapsible with a legend as the header, so the non-form collapsibles abuse form elements to appease activate_collapsibles. I altered activate_collapsibles and its CSS to work with any .collapsible, and changed the non-form users to use a div instead of a fieldset or legend. This makes the HTML slightly less invalid, and restores function in IE.

Before and after screenshot here: http://people.canonical.com/~wgrant/launchpad/involvement-portlet-config.png

[Steve Kowalik (stevenk)]

I'm not sure I like the thought of the other horrors that lurk in our codebase in terms of HTML5 or IE-compatibility, this looks like excellent work. And with the bonus of less code.

review: Approve (code)