Merge lp:~wgrant/launchpad/improved-html_escape into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | Steve Kowalik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16353 |
Proposed branch: | lp:~wgrant/launchpad/improved-html_escape |
Merge into: | lp:launchpad |
Diff against target: |
187 lines (+80/-48) 3 files modified
lib/lp/services/webapp/doc/menus.txt (+0/-20) lib/lp/services/webapp/escaping.py (+19/-28) lib/lp/services/webapp/tests/test_escaping.py (+61/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/improved-html_escape |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+138902@code.launchpad.net |
Commit message
Rewrite html_escape() and structured() and make them escape quotes in preparation for their deployment everywhere.
Description of the change
Rewrite html_escape and structured to be a bit more sensible and shorter. html_escape will now also escape single and double quotes. I rewrote the tests as well.
To post a comment you must log in.