Merge lp:~wgrant/launchpad/ic-fixes into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17017 | ||||
Proposed branch: | lp:~wgrant/launchpad/ic-fixes | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
154 lines (+21/-20) 4 files modified
lib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+6/-5) lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js (+2/-2) lib/lp/code/mail/codereviewcomment.py (+3/-4) lib/lp/code/mail/tests/test_codereviewcomment.py (+10/-9) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/ic-fixes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+220410@code.launchpad.net |
Commit message
Turn inline comments publish checkbox label into a real label, ensure that drafts are refreshed after publishing, and fix off-by-one error in inline comment email formatting.
Description of the change
Fix three easy bugs in inline comments:
- Turn 'Include X diff comments' into a label for the checkbox so it's possible to click without incredible precision.
- Ensure that drafts are refreshed from the server after publishing them, as we otherwise end up with weird ghost drafts that either don't appear or disappear until refresh.
- Fix inline comment off-by-one error. Comment dicts are 1-indexed, but the email formatter was accidentally just skipping line 0 instead of numbering from 1.