Merge lp:~wgrant/launchpad/i-am-stupid into lp:launchpad

[William Grant]

Add a few missing indices on AccessArtifactGrant and AccessPolicyGrant. Most notably on AccessPolicyGrant(grantee, policy), to accelerate person->APG lookups.

Add a few missing indices on AccessArtifactGrant and AccessPolicyGrant. Most notably on AccessPolicyGrant(grantee, policy), to accelerate person->APG lookups.

This fixes the performance of a lot of branch and bug permission checks, as they'll no longer have to do a sequential scan on AccessPolicyGrant to determine a person's granted policies.

[Stuart Bishop (stub)]

All looks fine.

review: Approve (db)

[Stuart Bishop (stub)]

We decided making the compound indexes UNIQUE is worthwile

[Stuart Bishop (stub)]

Applied to production and qastaging

=== added file 'database/schema/patch-2209-23-2.sql'
--- database/schema/patch-2209-23-2.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-23-2.sql	2012-09-10 10:10:27 +0000
@@ -0,0 +1,16 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE UNIQUE INDEX accesspolicygrant__grantee__policy__key
+    ON accesspolicygrant (grantee, policy);
+CREATE INDEX accesspolicygrant__grantor__idx
+    ON accesspolicygrant (grantor);
+
+CREATE UNIQUE INDEX accessartifactgrant__grantee__artifact__key
+    ON accessartifactgrant (grantee, artifact);
+CREATE INDEX accessartifactgrant__grantor__idx
+    ON accessartifactgrant (grantor);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 23, 2);