Merge lp:~wgrant/launchpad/garbo-feature-flags into lp:launchpad
Proposed by
William Grant
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 14845 | ||||
Proposed branch: | lp:~wgrant/launchpad/garbo-feature-flags | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
61 lines (+25/-1) 2 files modified
lib/lp/scripts/garbo.py (+6/-1) lib/lp/scripts/tests/test_garbo.py (+19/-0) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/garbo-feature-flags | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+93928@code.launchpad.net |
Commit message
[r=stub][bug=937501] Install a feature controller in garbo worker threads to unbreak BugHeatUpdater.
Description of the change
I yesterday changed the BugHeatUpdater garbo task to require a feature flag. But it turns out that it can't see the flag because garbo runs it in a thread with no feature controller.
This branch fixes garbo to install a feature controller when it starts a new thread, and adds a test that BugHeatUpdater vaguely works in a realish garbo environment.
To post a comment you must log in.
A generic feature flag test would be nice (but not required), as BugHeatUpdater will change over time.
Otherwise fine.