Merge lp:~wgrant/launchpad/edit-stacked-information-type into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ian Booth | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15621 | ||||
Proposed branch: | lp:~wgrant/launchpad/edit-stacked-information-type | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
156 lines (+46/-59) 2 files modified
lib/lp/code/browser/branch.py (+28/-55) lib/lp/code/browser/tests/test_branch.py (+18/-4) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/edit-stacked-information-type | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ian Booth (community) | Approve | ||
Review via email: mp+114767@code.launchpad.net |
Commit message
Stop special-casing private stacked-on branches so much on Branch:+edit.
Description of the change
This branch simplifies BranchEditView's handling of the information type of branches stacked on private branches. Previously it replaced the usual radio buttons with a disabled checkbox, and some text describing why it's locked. I've integrated this into the normal information type widget, so if the stacked-on branch is private it'll display only (branch.
There's no replacement for the warning text describing why the choices are restricted, but the case is uncommon enough that we probably don't care. It's already restricted by branch visibility policies without a corresponding warning.
Looks great.