Merge lp:~wgrant/launchpad/diff-no-newline into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Merged at revision: | 17618 |
Proposed branch: | lp:~wgrant/launchpad/diff-no-newline |
Merge into: | lp:launchpad |
Diff against target: |
53 lines (+14/-11) 2 files modified
lib/lp/code/mail/codereviewcomment.py (+12/-10) lib/lp/code/mail/tests/test_codereviewcomment.py (+2/-1) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/diff-no-newline |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kit Randel (community) | Approve | ||
Review via email: mp+264254@code.launchpad.net |
Commit message
Cope with "No newline at end of file" lines in diff emails, which bzrlib merges into the previous line.
Description of the change
Cope with "No newline at end of file" lines in diff emails, which bzrlib merges into the previous line. Look for NO_NL in patches.py to see the weird parsing implementation.
To post a comment you must log in.
Glad you added a comment; not what I would have expected!