Launchpad itself

Merge lp:~wgrant/launchpad/demolish-bvp into lp:launchpad

  1. demolish-bvp
  2. Merge into devel
Proposed by William Grant on 2012-10-09
Status: Merged
Approved by: Curtis Hovey on 2012-10-09
Approved revision: no longer in the source branch.
Merged at revision: 16129
Proposed branch: lp:~wgrant/launchpad/demolish-bvp
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~wgrant/launchpad/demolish-bvp
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code 2012-10-09 Approve on 2012-10-09
Review via email: mp+128610@code.launchpad.net

Commit Message

Drop BranchVisibilityPolicy from the code. Sharing is the new black.

Description of the Change

Delete all non-DB bits of BranchVisibilityPolicy. The modern sharing stuff is used instead.

I had to remove the tests for Branch:+edit's restrictions around transferring branches to owners that aren't permitted by the context, as sharing allows an authorised user to make anyone own a branch, so they can't be ported. This restriction will either be fully lifted or reimposed in a later branch, but for now the tests are gone.

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

Thank you.

Are you removing makeLegacyProduct() from factory in a separate branch?

review: Approve (code)

Preview Diff

Empty