Merge lp:~wgrant/launchpad/couple-of-oopses into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 17342 |
Proposed branch: | lp:~wgrant/launchpad/couple-of-oopses |
Merge into: | lp:launchpad |
Diff against target: |
62 lines (+12/-6) 3 files modified
lib/lp/buildmaster/model/buildfarmjobbehaviour.py (+7/-2) lib/lp/services/librarian/model.py (+2/-4) lib/lp/services/librarianserver/swift.py (+3/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/couple-of-oopses |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+249788@code.launchpad.net |
Commit message
Don't double-upload build results when the log download fails, don't squash IntegrityErrors in LibraryFileAlia
Description of the change
An OOPS fix, an OOPS change and an added OOPS:
- Bug #1422199: Minimise the risk of duplicate buildd-manager uploads
by moving the non-transactional filesystem operations as close to
the commit as possible. Previously the log download could time out
and abort the transaction after the upload had already been moved
into incoming/.
- Bug #1422207: Stop squashing IntegrityErrors in
LibraryFileA
waiting for the database to reject it and hoping that the error
we're catching is the right one. This will let us diagnose some odd
process-upload failures.
- Bug #1420046: Librarian's Swift ConnectionPool now verifies that
anything it's given is actually a swiftclient.
this will give us useful tracebacks at the source of the None
connections.