Merge lp:~wgrant/launchpad/bulk-insert into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14851 |
Proposed branch: | lp:~wgrant/launchpad/bulk-insert |
Merge into: | lp:launchpad |
Diff against target: |
212 lines (+139/-3) 2 files modified
lib/lp/services/database/bulk.py (+74/-2) lib/lp/services/database/tests/test_bulk.py (+65/-1) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bulk-insert |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Needs Fixing | |
Review via email: mp+93930@code.launchpad.net |
Commit message
[r=sinzui][no-qa] Introduce lp.services.
Description of the change
This branch adds lp.services.
It touches some of Storm's privates in inappropriate ways in order to handle References in a pretty (and typesafe) manner. Reference columns and values have to be flattened into (potentially compound) primary keys, and the methods to do that are private.
To post a comment you must log in.
Change the assert on line 82. It should be explicitly raised if the method has an integrity issue. Is this an AssertionError? I read "The Storm columns to insert values into. Must be from a single class", which implies this is a ValueError. Maybe?
if len(clses) == 1:
raise ValueError('The Storm columns to insert values into must be from a single class.')