Merge lp:~wgrant/launchpad/builderset-new-api into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Merged at revision: | 16986 |
Proposed branch: | lp:~wgrant/launchpad/builderset-new-api |
Merge into: | lp:launchpad |
Diff against target: |
189 lines (+64/-21) 5 files modified
lib/lp/buildmaster/configure.zcml (+3/-0) lib/lp/buildmaster/doc/builder.txt (+4/-2) lib/lp/buildmaster/interfaces/builder.py (+23/-15) lib/lp/buildmaster/tests/test_webservice.py (+30/-1) lib/lp/testing/factory.py (+4/-3) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/builderset-new-api |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+216861@code.launchpad.net |
Commit message
Export BuilderSet.new() on the webservice.
Description of the change
Export BuilderSet.new() on the webservice. All pretty trivial, except for moving BuilderSet.new to a new interface restricted by launchpad.Admin like the view.
To post a comment you must log in.
Looks good!
It seems to be a good compromise before re-thinking the buildmaster component for the Cloud(tm). However, since we do not have a remove() builders should be created with caution, even by Administrators.