Merge lp:~wgrant/launchpad/bug-750607 into lp:launchpad
Proposed by
William Grant
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13058 |
Proposed branch: | lp:~wgrant/launchpad/bug-750607 |
Merge into: | lp:launchpad |
Diff against target: |
110 lines (+53/-9) 3 files modified
lib/canonical/launchpad/security.py (+15/-8) lib/lp/code/tests/test_branch.py (+8/-0) lib/lp/code/tests/test_branchmergeproposal.py (+30/-1) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-750607 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | Approve | ||
Review via email: mp+61069@code.launchpad.net |
Commit message
[r=henninge][bug=750607] launchpad.View on BranchMergeProposal now requires launchpad.View on prerequisite_
Description of the change
Users can't see BranchMergeProp
This branch fixes the launchpad.View BranchMergeProposal adapter to require access to prerequisite_
To post a comment you must log in.
Ah, do you remember those days when lambdas were considered inappropriate in LP code? Good riddance! Welcome concise code using "map" and "all". Thanks for the reading pleasure. ;-)
I have one remark, though. Is there a reason for not using getUtility( ILaunchpadCeleb rities) .admin or are you simply not aware of it?
Cheers,
Henning