Launchpad itself

Merge lp:~wgrant/launchpad/bug-736002-seriously-this-time into lp:launchpad

  1. bug-736002-seriously-this-time
  2. Merge into devel
Proposed by William Grant
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 12844
Proposed branch: lp:~wgrant/launchpad/bug-736002-seriously-this-time
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt (+1/-1)
To merge this branch: bzr merge lp:~wgrant/launchpad/bug-736002-seriously-this-time
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+58016@code.launchpad.net

Commit message

Evaluate view/tags_cloud_data only once in +bugtarget-portlet-tags-content.

Description of the change

bugtarget-portlet-tags-content.pt was evaluating view/tags_cloud_data twice, so it was still timing out. This trivial branch makes it evaluate just once, hopefully avoiding timeouts.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt'
2--- lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt 2010-11-09 09:49:12 +0000
3+++ lib/lp/bugs/templates/bugtarget-portlet-tags-content.pt 2011-04-17 01:23:26 +0000
4@@ -6,7 +6,7 @@
5 <tal:tags content="cache:public noparam, 60 minutes">
6 <h2 tal:condition="tags_cloud_data">Tags</h2>
7 <div style="text-align: justify">
8- <a tal:repeat="tag_info view/tags_cloud_data"
9+ <a tal:repeat="tag_info tags_cloud_data"
10 tal:content="tag_info/tag"
11 tal:attributes="href tag_info/url;
12 style string:font-size: ${tag_info/factor}em" />