Merge lp:~wgrant/launchpad/bug-707808-unlanded-revisions into lp:launchpad
Proposed by
William Grant
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Penhey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12270 | ||||
Proposed branch: | lp:~wgrant/launchpad/bug-707808-unlanded-revisions | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
42 lines (+21/-1) 2 files modified
lib/lp/code/model/branchmergeproposal.py (+0/-1) lib/lp/code/model/tests/test_branchmergeproposal.py (+21/-0) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-707808-unlanded-revisions | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | code | Approve | |
Steve Kowalik (community) | code* | Approve | |
Review via email: mp+47617@code.launchpad.net |
Commit message
[r=stevenk,
Description of the change
r12246 removed the final uses of BranchRevision.id, but also erroneously added a new condition to BranchMergeProp
This branch removes that erroneous addition, and adds a test (the method was previously untested).
To post a comment you must log in.
Excellent work, and thanks for adding to our test coverage.