Merge lp:~wgrant/launchpad/bug-576168-no-disabled-latest-ppas into lp:launchpad

[William Grant]

Don't display uploads to disabled PPAs in the latest upload list.

A trivial branch to exclude publications within disabled PPAs from the latest upload list. Since normal users can't see these PPAs, they can't see publications inside them, causing bug #576168.

There is no lint.

[Michael Nelson (michael.nelson)]

Thanks William. I'll send it off to land.

review: Approve (code)

=== modified file 'lib/lp/soyuz/doc/archive.txt'
--- lib/lp/soyuz/doc/archive.txt	2010-04-29 23:06:26 +0000
+++ lib/lp/soyuz/doc/archive.txt	2010-05-06 10:41:29 +0000
@@ -1786,6 +1786,17 @@
     iceweasel 1.0 in breezy-autotest PUBLISHED mark
     pmount 0.1-1 in warty PUBLISHED cprov
 
+Publications in disabled archives are also excluded, since normal users
+can't see them.
+
+    >>> login("[e-mail]")
+    >>> cprov_cdrkit.archive.disable()
+    >>> print_latest_uploads()
+    cdrkit 1.0 in hoary PENDING mark
+    iceweasel 1.0 in hoary PENDING mark
+    iceweasel 1.0 in breezy-autotest PUBLISHED mark
+    >>> cprov_cdrkit.archive.enable()
+
 'getMostActivePPAsForDistribution' returns a list of dictionaries
 containing up to 5 PPAs with the highest number of publications in the
 last 7 days. Each dictionary contains the following keys:

=== modified file 'lib/lp/soyuz/model/archive.py'
--- lib/lp/soyuz/model/archive.py	2010-05-03 07:32:58 +0000
+++ lib/lp/soyuz/model/archive.py	2010-05-06 10:41:29 +0000
@@ -1681,6 +1681,7 @@
             SourcePackagePublishingHistory.distroseries =
                 DistroSeries.id AND
             Archive.private = FALSE AND
+            Archive.enabled = TRUE AND
             DistroSeries.distribution = %s AND
             Archive.purpose = %s
         """ % sqlvalues(distribution, ArchivePurpose.PPA)