Merge lp:~wgrant/launchpad/bug-1451107 into lp:launchpad
Proposed by
William Grant
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 17478 | ||||
Proposed branch: | lp:~wgrant/launchpad/bug-1451107 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
51 lines (+15/-1) 2 files modified
lib/lp/code/xmlrpc/git.py (+3/-1) lib/lp/code/xmlrpc/tests/test_git.py (+12/-0) |
||||
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-1451107 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+258328@code.launchpad.net |
Commit message
Fix GitAPI.notify for private branches.
Description of the change
The XMLRPC GitAPI.notify method runs as anonymous with web security, but needs to function for private branches too. This branch strips the security proxy from the branch before creating the scan job for it, which is fine as the method is idempotent, returns nothing, and takes no compromising input.
To post a comment you must log in.