Merge lp:~wgrant/launchpad/bug-1098170 into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 16416 |
Proposed branch: | lp:~wgrant/launchpad/bug-1098170 |
Merge into: | lp:launchpad |
Diff against target: |
108 lines (+40/-20) 2 files modified
lib/lp/registry/model/mailinglist.py (+8/-20) lib/lp/registry/tests/test_mailinglist.py (+32/-0) |
To merge this branch: | bzr merge lp:~wgrant/launchpad/bug-1098170 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+142816@code.launchpad.net |
Commit message
Fix MailingListSet.
Description of the change
This branch fixes a correctness bug in MailingListSet.
The bug was a single missing line in the second (non-preferred address) query:
MailingList
Without that, a TeamParticipation for any of the teams in the batch qualifies the person as a participant in *all* of the teams in the batch, even if they're actually only a former member in some of them.
Rather than fix the duplicated query, I rather chose to merge the preferred and non-preferred address cases into a single query.