Merge lp:~wgrant/launchpad/branch-type-policy-db into lp:launchpad/db-devel

[William Grant]

Add new columns to replace Product.private_bugs and BranchVisibilityPolicy.

This branch adds two new enum columns to replace Product.private_bugs and BranchVisibilityPolicy: Product.branch_sharing_policy and Product.bug_sharing_policy. lp:~wgrant/launchpad/branch-type-policy-model contains the initial app-side implementation of branch_sharing_policy, and bug_sharing_policy will be similar.

They should default to null for the time being, as that indicates to the app that the old model should be consulted instead.

[Robert Collins (lifeless)]

Why are the different? I mean, why isn't it one column?

review: Needs Information

[William Grant (wgrant)]

Consider pre-2009 Launchpad. Default public bugs, default private branches. It's by no means unique in this respect.

launchpad_dogfood=# SELECT COUNT(*) FROM product WHERE EXISTS (SELECT 1 FROM branchvisibilitypolicy WHERE branchvisibilitypolicy.product = product.id) AND NOT private_bugs;
 count
-------
   156
(1 row)

[Robert Collins (lifeless)]

kk

review: Approve

=== added file 'database/schema/patch-2209-26-0.sql'
--- database/schema/patch-2209-26-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2209-26-0.sql	2012-07-13 08:37:38 +0000
@@ -0,0 +1,11 @@
+-- Copyright 2012 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+-- Add new enum columns to replace Product.private_bugs and
+-- BranchVisibilityPolicy.
+ALTER TABLE product ADD COLUMN branch_sharing_policy integer;
+ALTER TABLE product ADD COLUMN bug_sharing_policy integer;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 26, 0);