Code review comment for lp:~weyrick/bzr/54624-warn-on-large-files

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/12/2011 4:55 PM, Shannon Weyrick wrote:
> All the goals have been met in the current patch, except 5 and 2. 5
> I'm not doing for now. 2 is a larger problem - some informal tests
> importing large trees show about 23% slowdown with the extra stat.
> Unfortunately I don't see a simple path towards sharing stat calls -
> they seem to be spread throughout the code now with no central way to
> cache. I'm looking into this further now.
>

Is it possible to put it in as part of get_file_with_stat or something
along those lines? That uses 'fstat' to make sure to stat the object
that is already in memory.

I do realize that add does things slightly differently, however we
already have the stat object around there, because we need to know if
the object is a file or a directory.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5FQbAACgkQJdeBCYSNAAOUoQCfXHL1daxOCO0opAic7nLjiMu8
GwQAn0xfkHedGsN3/DXM8/0w8kK5oxfa
=S28e
-----END PGP SIGNATURE-----

« Back to merge proposal