This all seems good to me.
The charm could be tidied up with support of charmhelpers, eg. using @hooks.hook instead of the if/then statement to invoke the correct hook handler. But that is unrelated to this branch, which is nicely contained and doesn't want the scope creep.
« Back to merge proposal
This all seems good to me.
The charm could be tidied up with support of charmhelpers, eg. using @hooks.hook instead of the if/then statement to invoke the correct hook handler. But that is unrelated to this branch, which is nicely contained and doesn't want the scope creep.