lp:~wesley-wiedenmeier/curtin/curtin-1543263

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 351

Server Team CI bot: Needs Fixing (continuous-integration) on 2016-02-12

Scott Moser (community): Approve on 2016-02-12

Diff: 95 lines (+49/-2)

3 files modified

curtin/commands/block_meta.py (+17/-1)
examples/tests/basic.yaml (+16/-0)
tests/vmtests/test_basic.py (+16/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1543263: doesn't support partitions with partition_number where a previous partition of that number doesn't exist

Critical

Fix Released

Link a bug report

Related blueprints

353. By Wesley Wiedenmeier on 2016-02-12

Added test case for partition numbering

352. By Wesley Wiedenmeier on 2016-02-12

Use better style string formatting for syslog

351. By Wesley Wiedenmeier on 2016-02-12

Dropped print statements and added a debug message for partition number

350. By Wesley Wiedenmeier on 2016-02-12

Add function find_previous_partition to find correct previous partition number
even if configuration requests partition numbers to be skipped.

Resolves LP: 1543263

349. By Scott Moser on 2016-02-11

Add strict flag to sys_block_path and verify path exists

This adds 'strict=True' to sys_block_path so it will verify that the
path exists and raise an ENOENT OSError if it does not.

348. By Scott Moser on 2016-02-11

vmtest: image_sync: fix removal of old directories

The net of these changes is that we now cleanup old directories
when we were not doing so before.

The changes specifically:
 - use remove_item rather than remove_version.
   remove_version had nothing in the data that was being passed
   to us as the tree had already had all the items removed from it.
   So when walking 'for item in ...' there were no items.
 - change a print to a LOG.info()
   info is admittedly a bit loud, but for now we want to see it.
 - remove_empty_dir:
   one clear bug fix. the indentation was broken and we would
   only call recursively if it *did* end with a /.

   instead remove trailing / before calling dirname.
   Now calls look like:
     remove_empty_dir("foo/bar/zee/////")
         # remove foo/bar/zee
         remove_empty_dir("foo/bar")
             remove_empty_dir("foo")

347. By Scott Moser on 2016-02-10

change mkfs.fat to mkfs.vfat and add dependency.

older versions of dosfstools did not provide a 'mkfs.fat'.
So we just use mkfs.vfat that does.

346. By Scott Moser on 2016-02-10

vmtest: fix importing of xenial images.

This cleans up the importing of images to use a simplestreams
mirror concept rather than the cmdline tools sstream-mirror and
sstream-query.

Theres a main in tests/vmtests/image_sync that allows query and
mirror from a cmdline interface:
   $ python3 -m tests.vmtests.image_sync query vmtest.d
   $ python3 -m tests.vmtests.image_sync mirror -vv \
      vmtest.d arch=amd64 release=trusty

The ./tools/vmtest-sync-images is still functional, and supports
a '--clean' option that clears the mirrors internal and derived data.
This might be useful in the event of a broken mirror output.

The default max images to keep is still 1, and old images should be
removed on a sync/mirror.

The mirror (IMAGE_DIR) now knows about the derived images and names them
vmtest.*. It can be mirrored with something like:
   sstream-mirror mirror $IMAGE_DIR out.d
If that was published on a http mirror, then http mirror would mean
no need of creating the derived files locally.

345. By Robert Clark on 2016-02-08

block-meta: use removable devices if no non-removable devices are found

Revision 202 changed behavior of curtin block-meta to not install to
'removable' devices. The intent was to avoid installing to usb drives.
The reality is that 'removable' was being read by what lsblk said, and
lsblk was proxying kernel's /sys/class/block/<device>/removable .

That 'removable' indication can even change from kernel to kernel.

344. By Scott Moser on 2016-01-19

mkfs: fix for lack of uuid on precise or trusty

the last merge for mkfs broke vmtest. Precise's version of btrfs
lacks both uuid and force flag. Trusty's lacks uuid.