lp:~wesley-wiedenmeier/curtin/1588875

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1562003: curtin has trouble removing partitions on redeployment	Medium	Fix Released
Bug #1588875: [2.0-b6] Deploying a trusty (but not xenial) node frequently fails during storage setup of curtin	Undecided	Fix Released

Link a bug report

Related blueprints

395. By Wesley Wiedenmeier on 2016-07-30

Merge from trunk

394. By Wesley Wiedenmeier on 2016-06-16

Fix trusty pep8 formatting issue

393. By Wesley Wiedenmeier on 2016-06-16

In block_meta.clear_holders, to handle holders that may have been shut down
since the holders list was retrieved, do not try to catch io errors, check
os.path.exists before operating on the holding device. this ensures that
the clear_holers function will work on python2 or python3, as the way file not
found exceptions were caught for python3 did not work on python2. This resolves
(LP: 1588875).

392. By Ryan Harper on 2016-06-15

reporting: set webhook handler level to DEBUG, no filtering

The webhook handler in curtin reporting included a default level
of INFO and included a event filter which would not report events
that were of lower importance than what was set. The result was
for unconfigured WebHook handlers, some of the expected messages
including post_files used by maas to collect the curtin install
log were no longer sent.

This patch sets WebHookHandler level to DEBUG, the same level set for
LogHandler and PrintHandler, further we remove the event filtering.
The events themselves include the level value and the event collector
can apply their own filtering as needed. Along with the changes we
clean up some comments and include a new unittest which specifically
tests that a FinishReportingEvent with post_files is posted by the
WebHookHandler.

391. By Scott Moser on 2016-06-14

improve net-meta network configuration

when network configuration is not provided 'net-meta' would write
a very simplistic /etc/network/interfaces file for each of the
devices that were brought up in install environment. This had the following
issues
a.) it did not disable cloud-init networking
b.) it did not account for naming of devices (causing issue if
    devices changed names between install and boot environment).
c.) did not include interfaces.d as ideally it would.

Now instead, we create a network config and let the appropriate renderer
do the work.

390. By Ryan Harper on 2016-06-04

curtin/net: fix inet value for subnets, don't add interface attributes to alias

Apply two separate fixes for configuring bonding with ip aliases.

Curtin re-used the interface's inet value for each subnet that might
be configured. In the case where the configuration included an ipv4
address after an ipv6 one resulted in emitting 'inet6' for ipv4 address
which is not correct. Resolve this issue by calculating the inet
value independent of the current status of the iface, using the subnet
config instead.

When rendering a network_config which includes ip alias interfaces
do not emit any attributes, like MTU, or bond/bridge options Including
these values is almost always wrong or will result in confusing
behavior on the target system.

389. By Ryan Harper on 2016-05-19

Detect and remove legacy /etc/network/interfaces.d/eth0.cfg from target

Prior to Xenial release, Ubuntu Cloud images included a default network
configuration in /etc/network/interfaces.d/eth0.conf. The presence of
this legacy configuration file can cause a delay during boot when cloud-
init is expecting a non-existent interface to become available. curtin
installations handle configuring networking in the target installed
system subsequently the embedded configuration is not needed.

This patch reuses most of cloud-init's version of detecting and
examining the legacy config, confirming if the contents are what is
expected. Upon finding expected content the file will be removed,
otherwise it will remain.

Additional changes to vmtest and unittest were added to remove the
reliance on fallback nic naming (eth0); we always use non-kernel names
in our configuration now. An additional common test has been added to
check that in all cases we ensure we remove the embedded config.

388. By Ryan Harper on 2016-05-19

vmtests: Add Xenial to LVM test bucket.

387. By Scott Moser on 2016-05-06

fix timestamp in reporting events.

If no timestamp was passed into a ReportingEvent, then the default was
used. That default was 'time.time()' which was evaluated once only at
import time.

386. By Scott Moser on 2016-05-05

debian/control: add bcache-tools dependency