Merge lp:~webkit-utils-core-editors/webkit-utils/7.0-port_of_base_header_webkit into lp:~webkit-utils-core-editors/webkit-utils/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Merged at revision: 14
Proposed branch: lp:~webkit-utils-core-editors/webkit-utils/7.0-port_of_base_header_webkit
Merge into: lp:~webkit-utils-core-editors/webkit-utils/7.0
Diff against target: 59 lines (+13/-12)
2 files modified
base_headers_webkit/__openerp__.py (+4/-2)
base_headers_webkit/base_headers_data.xml (+9/-10)
To merge this branch: bzr merge lp:~webkit-utils-core-editors/webkit-utils/7.0-port_of_base_header_webkit
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+140487@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Port of base header webkit to version 7

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_headers_webkit/__openerp__.py'
2--- base_headers_webkit/__openerp__.py 2012-12-18 14:25:12 +0000
3+++ base_headers_webkit/__openerp__.py 2012-12-18 16:23:25 +0000
4@@ -30,7 +30,9 @@
5 'version': '1.0',
6 'category': 'Reports/Webkit',
7 'description': """
8- Contains data headers and css to design standard reports, used by common modules like sale_order_wekbit, purchase_order_webkit, ...
9+ Contains data headers and css to design standard reports, used by common modules like:
10+ - sale_order_wekbit,
11+ - purchase_order_webkit, ...
12 """,
13 'author': 'Camptocamp',
14 'website': 'http://www.camptocamp.com',
15@@ -39,6 +41,6 @@
16 'update_xml': ['base_headers_data.xml'],
17 'demo_xml': [],
18 'test': [],
19- 'installable': False,
20+ 'installable': True,
21 'active': False,
22 }
23
24=== modified file 'base_headers_webkit/base_headers_data.xml'
25--- base_headers_webkit/base_headers_data.xml 2012-12-18 14:25:12 +0000
26+++ base_headers_webkit/base_headers_data.xml 2012-12-18 16:23:25 +0000
27@@ -65,15 +65,15 @@
28 <td/>
29 </tr>
30 <tr>
31- <td >${company.partner_id.address and company.partner_id.address[0].street or ''|entity}</td>
32- <td/>
33- </tr>
34- <tr>
35- <td>Phone: ${company.partner_id.address and company.partner_id.address[0].phone or ''|entity} </td>
36- <td/>
37- </tr>
38- <tr>
39- <td>Mail: ${company.partner_id.address and company.partner_id.address[0].email or ''|entity}<br/></td>
40+ <td >${company.partner_id.street or ''|entity}</td>
41+ <td/>
42+ </tr>
43+ <tr>
44+ <td>Phone: ${company.partner_id.phone or ''|entity} </td>
45+ <td/>
46+ </tr>
47+ <tr>
48+ <td>Mail: ${company.partner_id.email or ''|entity}<br/></td>
49 </tr>
50 </table> ${_debug or ''|n} </body>
51 </html>]]>
52@@ -201,7 +201,6 @@
53 </field>
54 <field name="name">Base Reports Portrait Header</field>
55 </record>
56-
57 <!-- ...................................MINIMALIST.......................................... -->
58 <record id="base_minimum_reports_portrait_header" model="ir.header_webkit">
59 <field name="footer_html"><![CDATA[

Subscribers

People subscribed via source and target branches