Code review comment for lp:~web2py/web2py/web2py-sphinx

Revision history for this message
yarko (yarkot) wrote :

Hi Tim -
I'll look at this later - but I think you have included sphinx build logs in
the revision (these should be removed).

Also - will you add the Makefile changes I sent you?

I'll look at more tomorrow.

Regards,
Yarko

On Wed, May 6, 2009 at 5:48 PM, Tim <email address hidden> wrote:

> You have been requested to review the proposed merge of
> lp:~web2py/web2py/web2py-sphinx into lp:~mdipierro/web2py/devel.
>
> >From the commit message:
>
> This is a 2nd setup and push of the Sphinx doc branch based on devel
> revision 750:
> * FAQ now optional
> * User Wiki now optional
> * still 36 warnings caused by the docstrings
> * the intro docs have been corrected and are free of errors and warnings
> Please provide feedback on the web2py mailing list
> The branch will be proposed for a merge with the devel branch.
>
> Reasons for this merge proposal:
> * current web2py/doc contains many errors
> * this branch provides a neat basis for further development of the Sphinx
> doc
> * this branch enables developers to test and improve docstrings
> * now after the commit of 750 a merge will be painless
>
> --
> https://code.launchpad.net/~web2py/web2py/web2py-sphinx/+merge/6276
> You are requested to review the proposed merge of
> lp:~web2py/web2py/web2py-sphinx into lp:~mdipierro/web2py/devel.
>

« Back to merge proposal