Merge lp:~wb-munzinger/ubuntu/precise/havp/fix-init-script into lp:ubuntu/precise/havp

Proposed by David Weber
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~wb-munzinger/ubuntu/precise/havp/fix-init-script
Merge into: lp:ubuntu/precise/havp
Diff against target: 56 lines (+11/-4)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/havp.init (+3/-3)
To merge this branch: bzr merge lp:~wb-munzinger/ubuntu/precise/havp/fix-init-script
Reviewer Review Type Date Requested Status
James Hunt (community) Approve
Oliver Grawert Needs Information
Dimitri John Ledkov Needs Fixing
Ubuntu branches Pending
Review via email: mp+125949@code.launchpad.net

Description of the change

Fixes the restart and reload problem.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

* please finalise changelog entry with target distribution (e.g. precise-proposed)
* please use the version number suitable for Stable Release Updates, e.g. best practice version numbering scheme is https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
* please update the maintainer line as the source package fails to build when above is done (e.g. update-maintainer command may help)

Above basically means that you really want two branches/debdiffs if you want this fix in quantal & precise.

review: Needs Fixing
24. By David Weber

Fix init script restart and force-reload

25. By David Weber

update init-script

Revision history for this message
Oliver Grawert (ogra) wrote :

looks fine, is there an SRU bug for it ? if so you should mention it in the changelog.

review: Needs Information
Revision history for this message
David Weber (wb-munzinger) wrote :

> looks fine, is there an SRU bug for it ? if so you should mention it in the
> changelog.
There is no SRU bug so far. Should I create one or can this be uploaded without?

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

David, you need to create the SRU bug. Please follow the guidelines in https://wiki.ubuntu.com/StableReleaseUpdates.

Revision history for this message
David Weber (wb-munzinger) wrote :
Revision history for this message
James Hunt (jamesodhunt) wrote :

Unclear why this MP hasn't auto-closed since it relates to a released branch. Maybe it needs an approval :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-05-19 12:25:29 +0000
3+++ debian/changelog 2012-10-02 13:05:34 +0000
4@@ -1,3 +1,9 @@
5+havp (0.92a-2ubuntu0.1) precise-proposed; urgency=low
6+
7+ * Fix init script restart and force-reload
8+
9+ -- David Weber <wb@munzinger.de> Mon, 24 Sep 2012 10:43:19 +0200
10+
11 havp (0.92a-2) unstable; urgency=low
12
13 * Include debconf language updates from previous NMU and new updates.
14
15=== modified file 'debian/control'
16--- debian/control 2011-04-06 17:42:05 +0000
17+++ debian/control 2012-10-02 13:05:34 +0000
18@@ -1,7 +1,8 @@
19 Source: havp
20 Section: net
21 Priority: optional
22-Maintainer: Rene Mayrhofer <rene.mayrhofer@gibraltar.at>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Rene Mayrhofer <rene.mayrhofer@gibraltar.at>
25 Build-Depends: debhelper (>= 4.0.0), autotools-dev, libssl-dev, libclamav-dev, dpatch, docbook-to-man, po-debconf
26 Standards-Version: 3.8.1
27
28
29=== modified file 'debian/havp.init'
30--- debian/havp.init 2011-05-19 12:25:29 +0000
31+++ debian/havp.init 2012-10-02 13:05:34 +0000
32@@ -87,7 +87,7 @@
33 #
34 echo "Reloading $DESC configuration files."
35 start-stop-daemon --stop --signal 1 --quiet --pidfile \
36- /var/run/$NAME.pid --exec $DAEMON || true
37+ $PIDFILE --exec $DAEMON || true
38 ;;
39 restart|force-reload)
40 #
41@@ -95,9 +95,9 @@
42 # option to the "reload" entry above. If not, "force-reload" is
43 # just the same as "restart".
44 #
45-+ $0 stop
46+ $0 stop
47 sleep 1
48-+ $0 start
49+ $0 start
50 ;;
51 status)
52 if [ ! -r $PIDFILE ]; then
53
54=== modified file 'debian/patches/03_havp.config.dpatch' (properties changed: -x to +x)
55=== modified file 'debian/patches/04_params.cpp.dpatch' (properties changed: -x to +x)
56=== modified file 'debian/patches/05_add_ssltimeout_option.dpatch' (properties changed: -x to +x)

Subscribers

People subscribed via source and target branches

to all changes: