Merge ~waveform/ubuntu/+source/ubuntu-settings:network-manager into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

Proposed by Dave Jones
Status: Merged
Merged at revision: 91b68cdbb7b8213afb097d36a7ac92f2132705b7
Proposed branch: ~waveform/ubuntu/+source/ubuntu-settings:network-manager
Merge into: ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Diff against target: 91 lines (+42/-0)
6 files modified
data/ubuntu/00-network-manager-all.yaml (+4/-0)
debian/changelog (+8/-0)
debian/rules (+3/-0)
debian/ubuntu-settings.install (+1/-0)
debian/ubuntu-settings.postinst (+23/-0)
meson.build (+3/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian Approve
Review via email: mp+443210@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Thank you, lgtm!

This should probably be release noted for Mantic.

review: Approve
Revision history for this message
Dave Jones (waveform) wrote :

Agreed -- I'll stick it in the notes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/data/ubuntu/00-network-manager-all.yaml b/data/ubuntu/00-network-manager-all.yaml
2new file mode 100644
3index 0000000..4a8fd08
4--- /dev/null
5+++ b/data/ubuntu/00-network-manager-all.yaml
6@@ -0,0 +1,4 @@
7+# Let NetworkManager manage all devices on this system
8+network:
9+ version: 2
10+ renderer: NetworkManager
11diff --git a/debian/changelog b/debian/changelog
12index e6eea71..dc0b3b2 100644
13--- a/debian/changelog
14+++ b/debian/changelog
15@@ -1,3 +1,11 @@
16+ubuntu-settings (23.10.1) UNRELEASED; urgency=medium
17+
18+ * ubuntu-settings: migrated (unowned, livecd-rootfs hack based) netplan
19+ network-manager configuration to /lib/netplan from /etc/netplan
20+ (LP: #2020110)
21+
22+ -- Dave Jones <dave.jones@canonical.com> Thu, 18 May 2023 15:34:12 +0100
23+
24 ubuntu-settings (23.04.5) lunar; urgency=medium
25
26 * ubuntu-raspi-settings-desktop: Don't attempt to prepare oem-config in
27diff --git a/debian/rules b/debian/rules
28index 2e1de50..eb51c58 100755
29--- a/debian/rules
30+++ b/debian/rules
31@@ -3,6 +3,9 @@
32 %:
33 dh $@ --with translations
34
35+override_dh_fixperms:
36+ dh_fixperms --exclude lib/netplan/00-network-manager-all.yaml
37+
38 override_dh_missing:
39 dh_missing --fail-missing
40
41diff --git a/debian/ubuntu-settings.install b/debian/ubuntu-settings.install
42index 7e32f86..cee8364 100644
43--- a/debian/ubuntu-settings.install
44+++ b/debian/ubuntu-settings.install
45@@ -1,2 +1,3 @@
46 usr/share/ubuntu
47 usr/share/ubuntu-wayland
48+lib/netplan/00-network-manager-all.yaml
49diff --git a/debian/ubuntu-settings.postinst b/debian/ubuntu-settings.postinst
50new file mode 100644
51index 0000000..61a0dd9
52--- /dev/null
53+++ b/debian/ubuntu-settings.postinst
54@@ -0,0 +1,23 @@
55+#!/bin/sh
56+
57+set -e
58+
59+case "$1" in
60+ configure)
61+ # Remove the obsolete (unpackaged) netplan config file (if unmodified),
62+ # or moved it to .dpkg-backup (if modified). This isn't done with
63+ # dpkg-maintscripts because those require the prior version was owned
64+ # by the package (and this file is owned by nothing).
65+ NM_CONF="/etc/netplan/01-network-manager-all.yaml"
66+ if [ -e "$NM_CONF" ]; then
67+ if [ "$(md5sum "$NM_CONF" | cut -d" " -f1)" = "81c200b0e29eeb56c518a23eb78777ab" ]; then
68+ rm -f "$NM_CONF"
69+ else
70+ echo "Moving modified $NM_CONF to .dpkg-backup" >&2
71+ mv -f "$NM_CONF" "${NM_CONF}.dpkg-backup"
72+ fi
73+ fi
74+ ;;
75+esac
76+
77+#DEBHELPER#
78diff --git a/meson.build b/meson.build
79index 28fd7ef..75c2444 100644
80--- a/meson.build
81+++ b/meson.build
82@@ -19,6 +19,9 @@ install_data('data/ubuntu/applications/info.desktop',
83 install_dir: datadir+'/ubuntu/applications/')
84 install_data('data/ubuntu/applications/texdoctk.desktop',
85 install_dir: datadir+'/ubuntu/applications/')
86+install_data('data/ubuntu/00-network-manager-all.yaml',
87+ install_dir: '/lib/netplan',
88+ install_mode: 'rw-------')
89 foreach dir : ['data/ubuntu-wayland', 'data/icons']
90 install_subdir(dir, install_dir: datadir)
91 endforeach

Subscribers

People subscribed via source and target branches

to all changes: