Merge lp:~wallyworld/launchpad/subscription-policy-text-912159 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14687 |
Proposed branch: | lp:~wallyworld/launchpad/subscription-policy-text-912159 |
Merge into: | lp:launchpad |
Diff against target: |
144 lines (+54/-4) 5 files modified
lib/lp/app/widgets/doc/launchpad-radio-widget.txt (+13/-0) lib/lp/app/widgets/itemswidgets.py (+17/-2) lib/lp/app/widgets/tests/test_itemswidgets.py (+9/-0) lib/lp/registry/browser/team.py (+9/-2) lib/lp/registry/browser/tests/test_team_view.py (+6/-0) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/subscription-policy-text-912159 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+88808@code.launchpad.net |
Commit message
[r=sinzui][bug=912159] Add informative text to team edit page explaining why subscription policy choices are limited.
Description of the change
== Implementation ==
The tal template uses a form macro to render all the widgets, including the subscription policy radio buttons, so I decided to extend the LaunchpadRadioW
- extra_hint
- extra_hint_class
I could have simply added text to the widget's hint text. However, I feel the extra information required here is different to the standard (static) widget hint attribute which is derived from the form field definition. The extra hint value is designed to provide the user with more than just text describing what a field does. It needs to convey info about the available choices and will not be static.
The text for the extra hint comes from the message in the exception raised when checking what vocab to use for the widget.
== Demo and QA ==
See screenshot:
http://
I'm not sure if the extra hint text should be rendered the same lighter grey as the other text - opinions welcome.
== Tests ==
Tests were written for the new LaunchpadRadioW
Add to doc test:
- launchpad-
Add new test case to TestLaunchpadRa
- test_renderExtr
Extend the TestTeamEditView tests to check the extra hint attributes have been set (or not) on the widget:
- _test_edit_
- test_edit_
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
I like the implementation (I really like the reuse of the exception). Why did you define the 'inline- informational' class? It looks like "sprite info"...sprite is inline and info is informational. Did you try that and was the layout broken?