Merge lp:~wallyworld/launchpad/subscriber-portlet-spinner into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Ian Booth |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13594 |
Proposed branch: | lp:~wallyworld/launchpad/subscriber-portlet-spinner |
Merge into: | lp:launchpad |
Diff against target: |
93 lines (+14/-14) 2 files modified
lib/lp/app/javascript/subscribers/subscribers_list.js (+3/-2) lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js (+11/-12) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/subscriber-portlet-spinner |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+70247@code.launchpad.net |
Commit message
[r=stevenk][bug=820146] Small fix to display the Subscribing... spinner as soon as the "Subscribe Me" link is clicked.
Description of the change
Small fix to display the Subscribing... spinner as soon as the "Subscribe Me" link is clicked.
== Implementation ==
The subscription portlet normally needs to first retrieve the subscribee details (via an xhr call) in order to indicate progress and do the next step in the subscribe process. However, in the case of "Subscribe Me" where the subscribers list is not to be updated, then the spinner can be displayed before this first xhr is made.
== Tests ==
Update a couple of test_subscriber
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/