Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Ian Booth (wallyworld) wrote :

>
>>
>> What I've done now is to make the <fieldset> element which contains
>> everything for the related branches widget a fixed size and remove the
>> width styling from the tables. The resize behaviour is the same as
>> described above but I think it's a cleaner implementation.
>
> Do you really think we should go with the fixed width, even with all its
> drawbacks?
>

Without the fixed width, the tables expand right out to the edge of the
browser window, and on a screen with the browser maximised for example,
it looks really bad (to my eye) when all the form elements are around
the same width (approx size of text area widget) and just the related
branches tables are really wide. In my view, it's better visually to try
and maintain a similar width for all the form widgets and a consistent
resize behaviour ie if the text area widget is fixed, the the tables
(via the width styling on the fieldset element) should be too. When the
tables are really wide without the fixed width, the first column expands
way out and there's a lot of empty space and your eye is forced to scan
all the way to the right to see the 2nd table column. Do you agree with
this view? I'm not an css expert so I'd love to hear about any issues
with using the current fixed width approach that outweigh the positive
benefits outlined above.

« Back to merge proposal