Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Ian Booth (wallyworld) wrote :

> The column width issue is the same one that the milestone and project packages
> pages had to solve. User really do need the columns to be the same size and
> aligned to scan the page. But as Salgado notes, the columns do not have the
> same content. This is a bit like the related packages problem (see
> https://launchpad.net/~wgrant/+related-software for packages and ppa). This
> data issue might not be solvable now, but it would be nice to have the same
> column headings.
>

Do we want the same styling to be used here as on the related software page listed above? That would have been my preferred way of doing it - bold table heading text etc. I just used the CCS class "listing" for the table style because I thought that was the correct thing to do. It would be good to change the look of my page to match the one referenced.

> I think Salgado has an interesting point about showing the URL
> I suspect such a change will frustrate users who copy the branch URL from the
> listing. But I wonder. Why is the owner missing from the product URLs?
>
> So I think Salgado is asking the right question. I would rephrase it as "Why
> isn't the data symmetric?"

I agree it would be better to have the same column headings etc. The main reason the two tables have different headings is that the branch urls are so long and I didn't want them to wrap and so was limited in how much space could be devoted to adding other columns. Initial implementation discussion resulting in the key info being chosen for display for each branch type and although I could have displayed owner for source package branches (for example), decided not to in order to limit the required table width.

When I didn't limit the table width, the tables came out very wide - see the screenshot from the original implementation: http://people.canonical.com/~ianb/recipe-related-branches.png
The screenshot lacks the vertical space between the tables, and the columns are each very wide and so the tables could easily accommodate more columns with extra info being added, but I think it the ui looks terrible given the tables are so much wider than the other data entry widgets on the recipe form??

If we are happy to have the tables wider, I could look to make the data in each symmetric....

« Back to merge proposal