Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Tue, 2011-01-25 at 20:07 +0000, Curtis Hovey wrote:
> The column width issue is the same one that the milestone and project
> packages pages had to solve. User really do need the columns to be the
> same size and aligned to scan the page. But as Salgado notes, the
> columns do not have the same content. This is a bit like the related
> packages problem (see https://launchpad.net/~wgrant/+related-software
> for packages and ppa). This data issue might not be solvable now, but
> it would be nice to have the same column headings.
>
> I think Salgado has an interesting point about showing the URL
> I suspect such a change will frustrate users who copy the branch URL
> from the listing. But I wonder. Why is the owner missing from the
> product URLs?

I can see why people would copy the branch URL if they wanted to use
that in the recipe but I was under the impression the main use case here
was just to show stuff that the user might like to know rather than to
aid them in crafting the recipe. That was my understanding after
reading https://bugs.launchpad.net/launchpad/+bug/670452/comments/2 but
maybe I misunderstood or the main use case is to aid people writing
recipes?

« Back to merge proposal