Code review comment for lp:~wallyworld/launchpad/recipe-find-related-branches

Revision history for this message
Guilherme Salgado (salgado) wrote :

Hi Ian,

This looks like I nice addition, but I wonder if it's necessary to list the branch URLs or if it'd be enough to have just the branch's name (linking to the branch itself) and the series/package name (also linking to the relevant thing). Something like

v Related branches[1]

 ------------------------------------------------------------------------
 | From source packages | Owner |
 ------------------------------------------------------------------------
 | _firefox-4.0_ from the _We're back in the game_ series | TheOwner |

 -----------------------------------------------------------------
 | From product series | Owner |
 -----------------------------------------------------------------
 | _bzr-2.2_ from the _Bazaar 2.2_ series | TheOwner |

That makes (what seems to me to be) the important information more prominent, avoids the repetition, provides a link to the series/packages themselves and allows us to use similar table headings for both tables (having one table list the owner and the other just the source package seemed a bit weird to me, but maybe there's a reason for doing so?).

Also, do you really need the fixed width on the table? Shouldn't the surrounding boxes of the launchpad-form limit the width of the table? Or is this because you want them to have the exact same width as the recipe text area?

[1] notice the different capitalization, as recommended by https://dev.launchpad.net/UserInterfaceWording

review: Needs Information (ui*)

« Back to merge proposal