Code review comment for lp:~wallyworld/launchpad/recipe-build-now

Revision history for this message
Ian Booth (wallyworld) wrote :

> don't pay attention. Or they have tunnel vision. ;-) In any case, the action
> needs a feedback about success or failure in the same place where it is
> requested. So it should go: <icon> Build now -> <spinner> Requesting build ...
> -> <checkmark or info> 2 builds have been queued OR <error> Request failed.
> That response does not have to survive a page reload, though.

Hi Henning

I have added an informational message which appears when the ajax "Build now" action completes. The screenshot below shows how it looks:

This message replaces the "Requesting build..." spinner once the request completes and uses a timer so that after 20 seconds, the message disappears.

Hopefully this is sufficient :-)

« Back to merge proposal