Merge lp:~wallyworld/launchpad/recipe-build-now into lp:launchpad

[Ian Booth]

[r=thumper][ui=henninge][bug=687623,720474] Add a link/button on the recipe index page to allow a daily build to be manually initiated.

This change provides a way to allow users to manually request that a daily build of a recipe should be queued "now". This feature is only available if the recipe is configured to build daily and is marked as stale.

= =Implementation ==

A new view was written - SourcePackageRecipeRequestDailyBuildView
This view handles both the ajax and non-ajax cases. The request.is_ajax flag is used to see if it's an ajax call. If so, a different page template is used to just load the recipe builds and this info is returned to be inserted directly into the page without a refresh. For the non-ajax case, a page refresh is used to reload the entire recipe page and hence show the new pending builds.

In the case where there is already a build for one or more of the distroseries pending, no error is shown. Any new builds are simply displayed.

A new sprite was added - sourcepackage-recipe-build.png. This is used as the icon to display next to the ajax "Build now" link.

A drive by fix was done to the recipe vocabularies for archives and distroseries since they borked when the recipe index page was shown without a user logged in.

== Demo and QA ==

The following screenshots show how the link/button looks for the script and no script case

http://people.canonical.com/~ianb/request-daily-build.png
http://people.canonical.com/~ianb/request-daily-build-no-ajax.png

To QA, you just need to ensure there's an appropriate recipe available (stale, build daily etc) and click the "Build now" link. The link should then disappear and the Recent Builds table be updated.

== Tests ==

A Windmill test was written to test that the ajax enabled "Build now" link works.
Unit tests were written to check that the "Build now" feature only shows when relevant and to check the no script version.

bin/test -vvt test_sourcepackagerecipe
bin/test -vvt test_recipe_request_build

[Henning Eggers (henninge)]

Hi Ian,
thank you for this simple fix and taking the time to include some ajax and graceful degradation. It seems to work nicely but I do have a couple of issues I'd like to see addressed:

- I am not sure why the non-ajax case needs to include a button and does not get the nice new icon. Do we do that in other places already? The original idea was that ajax-enabled links are green, others blue and I think that still holds. This may be different here, though, because the link does not lead to a new page but simply starts an action on the same page. So the button may be OK if it is for that reason.
- The non-ajax case definitely needs some feed back. This is usually achieved by using the message boxes at the top of the page. "The build has been requested, see the Latest Builds table below." or something like that.
- The ajax case has a nice "requesting build" spinner when you click it but then just simply disappears. This leaves the user at a loss if the operation succeeded or not. (Can it fail btw?) A possible feedback might be to flash the Latest Builds table green, or rather the lines of the builds being started.
- The feed-back problem also made me think if the button is placed correctly in the first place. I actually think it should be placed by the table (which represents operational data about the builds) and not in the recipe information (which represents static data about the recipe). While writing this, I became very sure that it has to be moved. It should go right under the "Latest builds" heading in a line expressing the current state ("it is stale" but worded better ;).

On the whole this fix is a really nice start but I have to ask you to please fix the feed-back deficiencies before I can sign this off.

Cheers,
Henning

review: Needs Fixing (ui)

[Ian Booth (wallyworld)]

Hi Henning

Thanks for the detailed feedback. It's appreciated.

On 17/02/11 17:56, Henning Eggers wrote:
> Review: Needs Fixing ui
> Hi Ian,
> thank you for this simple fix and taking the time to include some ajax and graceful degradation. It seems to work nicely but I do have a couple of issues I'd like to see addressed:
>
> - I am not sure why the non-ajax case needs to include a button and does not get the nice new icon. Do we do that in other places already? The original idea was that ajax-enabled links are green, others blue and I think that still holds. This may be different here, though, because the link does not lead to a new page but simply starts an action on the same page. So the button may be OK if it is for that reason.

A form submission (post) is required for this operation in order to
start a write transaction. The issue is that without javascript a form
submission can be done with either a button or an image, but not a link.
In other similar places to this, we use a button (eg the vote or claim
review buttons on the mp page). Since buttons are used elsewhere for
this type of operation, I stuck with that convention. The alternative
was to go with an image that is done to look like a button or similar
but that's not done anywhere else. Because a post is required, a (blue)
link is not sufficient since that only does a get and starts a readonly
transaction.

> - The non-ajax case definitely needs some feed back. This is usually achieved by using the message boxes at the top of the page. "The build has been requested, see the Latest Builds table below." or something like that.

Good idea. Thanks. I'll do that.

> - The ajax case has a nice "requesting build" spinner when you click it but then just simply disappears. This leaves the user at a loss if the operation succeeded or not. (Can it fail btw?) A possible feedback might be to flash the Latest Builds table green, or rather the lines of the builds being started.

Any new builds rows are indeed flashed green using the standard yui
anim() call that we use in lp. Note that if any daily builds which
result from the Build Now click are already pending, they are not
reflashed. However this should be very rare,since the Build Now only
appears if the recipe is stale. Perhaps you missed seeing the row animation?

> - The feed-back problem also made me think if the button is placed correctly in the first place. I actually think it should be placed by the table (which represents operational data about the builds) and not in the recipe information (which represents static data about the recipe). While writing this, I became very sure that it has to be moved. It should go right under the "Latest builds" heading in a line expressing the current state ("it is stale" but worded better ;).
>

Ok. I'll mock something up and see how that looks.

> On the whole this fix is a really nice start but I have to ask you to please fix the feed-back deficiencies before I can sign this off.
>

No problem. The feedback was very good. Thanks.

[Ian Booth (wallyworld)]

>
> > - The feed-back problem also made me think if the button is placed correctly
> in the first place. I actually think it should be placed by the table (which
> represents operational data about the builds) and not in the recipe
> information (which represents static data about the recipe). While writing
> this, I became very sure that it has to be moved. It should go right under the
> "Latest builds" heading in a line expressing the current state ("it is stale"
> but worded better ;).
> >
>
> Ok. I'll mock something up and see how that looks.
>

A further thought on this. The Build Now link was put next to the recipe build_daily field on the ui because the two belong together. The Build Now link is only shown if the build_daily field is true. So it makes sense they are rendered together. The trouble with putting it in the builds table is that it decreases the visual association with the build_daily field which controls its existence. Also, using the words "is stale" or similar has a negative connotation and suggests to the user that action is required on their part to "correct" some problem. But there's no real problem as such and users may be enticed to keep selecting Build Now when the next scheduled daily build will take care of it. If the browser window is a largish size, then the new build rows will be visible when they are flashed green so that does give feedback that "something" has happended.

[Henning Eggers (henninge)]

Re: the non-ajax button

I had not made the connection to the form-submitting issue. In that case the button is appropriate, of course, as has been done elsewhere.

Re: Location of the link

I don't think the configurational relation of the daily build option and the availability of the action weighs heavier than the work flow for the user. Requesting an action must result in some visible change for the user but simply the option disappearing is not enough. That's why I think it should be moved to the table which is directly affected by the action. We cannot rely on a "largish size" of the browser window. On my laptop screen the top of the table is barely visible, even using chromium. Also, I just tried it a again and did not see a green flash at all but that might just me playing with the database to set the "stale" flag. ;-)

Re: "stale"

Sorry, I did not mean to put "stale" in the UI that's what I meant by "but worded better".

How about this (I am not sure if I got the wording right, though):

"<icon> There are no pending builds. _Build_now_"

After clicking _Build_now_:

"<icon> Build queued."
or
"<icon> Build pending"
or
"<icon> Next build in 10 hours" (if that is possible).

I could even go along with that being done in the old place but I am still not totally happy with mixing static and operational information. Also, it is probably doubling information from the Latest build table? My preference remains to place it on top of the table.

Also, I just noticed something else. Changing "Built daily" to "Built on request" (ajax popup) and back does not hide or show the new link. It takes a page reload to hide/show it. For the story to be complete, this should work in ajax, too.

Henning

[Ian Booth (wallyworld)]

Hi again

> RE: placement of Build Now button/link

I'll talk to Tim about the (valid) issues you raise and see what his
preferred option is etc.

>
> Also, I just noticed something else. Changing "Built daily" to "Built on request" (ajax popup) and back does not hide or show the new link. It takes a page reload to hide/show it. For the story to be complete, this should work in ajax, too.
>

Yes, this is a current known limitation and we are waiting on work by
Leonard on the javascript/webservices side before this issue can be
addressed. Good job on noticing it :-)

[Tim Penhey (thumper)]

Henning,

This has all come from me, and Ian has provided what I asked for.

This is a specific action that only applies to daily builds, and as such, it should be next to the visual representation of the build schedule. This is where I want it.

We do have a "Request builds" action that is either in or next to the build table.

Tim

[Tim Penhey (thumper)]

As discussed over mumble, there are a few things to fix.

review: Needs Fixing

[Ian Booth (wallyworld)]

Henning,

I've added a page notification for the html request build form and also the Build now button to give feedback since the new build rows cannot be flashed green.

http://people.canonical.com/~ianb/new-build-notification.png

I've kept the message simple: "x new recipe builds have been queued."
I experimented with attempting to list the new builds but in the end think simple is best.

[Henning Eggers (henninge)]

Tim,
ok, I understand the reasoning for the placement of the link and I am happy to go along with it now. What I cannot go along with, though, is that it simply disappears when the user clicks on it. I am using a larger screen today and so I see the green flash on the table but I am certain that users will be be missing it just like I did on my smaller laptop screen yesterday. Or they don't pay attention. Or they have tunnel vision. ;-) In any case, the action needs a feedback about success or failure in the same place where it is requested. So it should go: <icon> Build now -> <spinner> Requesting build ... -> <checkmark or info> 2 builds have been queued OR <error> Request failed. That response does not have to survive a page reload, though.

Ian,
the page notification looks good, thanks for adding that. ;)

Henning

[Ian Booth (wallyworld)]

> don't pay attention. Or they have tunnel vision. ;-) In any case, the action
> needs a feedback about success or failure in the same place where it is
> requested. So it should go: <icon> Build now -> <spinner> Requesting build ...
> -> <checkmark or info> 2 builds have been queued OR <error> Request failed.
> That response does not have to survive a page reload, though.

Hi Henning

I have added an informational message which appears when the ajax "Build now" action completes. The screenshot below shows how it looks:

http://people.canonical.com/~ianb/new-build-ajax-notification.png

This message replaces the "Requesting build..." spinner once the request completes and uses a timer so that after 20 seconds, the message disappears.

Hopefully this is sufficient :-)

[Henning Eggers (henninge)]

Looks great, thanks for adding this. ;-)

review: Approve (ui)

[Tim Penhey (thumper)]

review: Approve (code)

=== modified file 'lib/canonical/launchpad/icing/icon-sprites'
Binary files lib/canonical/launchpad/icing/icon-sprites	2010-06-11 18:39:35 +0000 and lib/canonical/launchpad/icing/icon-sprites	2011-02-23 10:25:23 +0000 differ
=== modified file 'lib/canonical/launchpad/icing/icon-sprites.positioning'
--- lib/canonical/launchpad/icing/icon-sprites.positioning	2010-10-31 20:18:45 +0000
+++ lib/canonical/launchpad/icing/icon-sprites.positioning	2011-02-23 10:25:23 +0000
@@ -3,7 +3,7 @@
 {
     "../images/arrowLeft.png": [
         0, 
-        -14754
+        -14918
     ], 
     "../images/cancel.png": [
         0, 
@@ -13,9 +13,9 @@
         0, 
         -3440
     ], 
-    "../images/zoom-out.png": [
+    "../images/build-needed.png": [
         0, 
-        -11966
+        -13442
     ], 
     "../images/team.png": [
         0, 
@@ -43,7 +43,7 @@
     ], 
     "../images/arrowTop.png": [
         0, 
-        -14426
+        -14590
     ], 
     "../images/zoom-in.png": [
         0, 
@@ -55,23 +55,23 @@
     ], 
     "../images/blue-bar.png": [
         0, 
-        -14918
+        -15082
     ], 
     "../images/arrowStart.png": [
         0, 
-        -14098
+        -14262
     ], 
     "../images/ppa-icon-inactive.png": [
         0, 
         -12458
     ], 
-    "../images/build-needed.png": [
+    "../images/zoom-out.png": [
         0, 
-        -13278
+        -11966
     ], 
     "../images/purple-bar.png": [
         0, 
-        -15246
+        -15410
     ], 
     "../images/bullet.png": [
         0, 
@@ -79,11 +79,11 @@
     ], 
     "../images/info-large.png": [
         0, 
-        -17340
+        -17504
     ], 
     "../images/trash-logo.png": [
         0, 
-        -20358
+        -20340
     ], 
     "../images/warning.png": [
         0, 
@@ -95,35 +95,35 @@
     ], 
     "../images/build-failure.png": [
         0, 
-        -13442
+        -13606
     ], 
     "../images/branch-large.png": [
         0, 
-        -16066
+        -16230
     ], 
     "../images/download-large.png": [
         0, 
-        -17158
+        -17322
     ], 
     "../images/private-large.png": [
         0, 
-        -18250
+        -18232
     ], 
     "../images/launchpad-large.png": [
         0, 
-        -17522
+        -17686
     ], 
     "../images/translation-file.png": [
         0, 
         -10818
     ], 
-    "../images/read-only.png": [
+    "../images/source-package-recipe.png": [
         0, 
-        -9998
+        -12622
     ], 
     "../images/project-logo.png": [
         0, 
-        -18860
+        -18842
     ], 
     "../images/bug-medium.png": [
         0, 
@@ -135,7 +135,7 @@
     ], 
     "../images/tour-icon": [
         0, 
-        -15902
+        -16066
     ], 
     "../images/trash-icon.png": [
         0, 
@@ -147,7 +147,7 @@
     ], 
     "../images/arrowBottom.png": [
         0, 
-        -14590
+        -14754
     ], 
     "../images/project.png": [
         0, 
@@ -173,17 +173,13 @@
         0, 
         -3768
     ], 
-    "../images/stop.png": [
-        0, 
-        -11310
-    ], 
     "../images/person-logo.png": [
         0, 
-        -19288
+        -19270
     ], 
     "../images/distribution-logo.png": [
         0, 
-        -18646
+        -18628
     ], 
     "../images/retry.png": [
         0, 
@@ -199,7 +195,7 @@
     ], 
     "../images/merge-proposal-icon.png": [
         0, 
-        -12786
+        -12950
     ], 
     "../images/download.png": [
         0, 
@@ -207,7 +203,7 @@
     ], 
     "../images/arrowDown.png": [
         0, 
-        -13934
+        -14098
     ], 
     "../images/package-binary.png": [
         0, 
@@ -219,11 +215,11 @@
     ], 
     "../images/bug-status-expand.png": [
         0, 
-        -12622
+        -12786
     ], 
     "../images/crowd-large.png": [
         0, 
-        -16430
+        -16594
     ], 
     "../images/blueprint.png": [
         0, 
@@ -245,9 +241,13 @@
         0, 
         -6228
     ], 
+    "../images/stop.png": [
+        0, 
+        -11310
+    ], 
     "../images/flame-large.png": [
         0, 
-        -16976
+        -17140
     ], 
     "../images/bug-dupe-icon.png": [
         0, 
@@ -259,11 +259,11 @@
     ], 
     "../images/build-success.png": [
         0, 
-        -13114
+        -13278
     ], 
     "../images/haspatch-icon.png": [
         0, 
-        -15738
+        -15902
     ], 
     "../images/person-inactive-badge.png": [
         0, 
@@ -279,7 +279,7 @@
     ], 
     "../images/team-logo.png": [
         0, 
-        -19716
+        -19698
     ], 
     "../images/arrowRight.png": [
         0, 
@@ -311,7 +311,7 @@
     ], 
     "../images/arrowUp.png": [
         0, 
-        -13770
+        -13934
     ], 
     "../images/distribution.png": [
         0, 
@@ -319,11 +319,11 @@
     ], 
     "../images/error-large.png": [
         0, 
-        -16794
+        -16958
     ], 
     "../images/news.png": [
         0, 
-        -15574
+        -15738
     ], 
     "../images/treeExpanded.png": [
         0, 
@@ -331,7 +331,7 @@
     ], 
     "../images/build-depwait.png": [
         0, 
-        -13606
+        -13770
     ], 
     "../images/blueprint-essential.png": [
         0, 
@@ -351,7 +351,7 @@
     ], 
     "../images/product-logo.png": [
         0, 
-        -19074
+        -19056
     ], 
     "../images/blueprint-medium.png": [
         0, 
@@ -367,11 +367,11 @@
     ], 
     "../images/launchpad-logo.png": [
         0, 
-        -18432
+        -18414
     ], 
     "../images/flame-logo.png": [
         0, 
-        -20144
+        -20126
     ], 
     "../images/translation-template.png": [
         0, 
@@ -383,7 +383,7 @@
     ], 
     "../images/meeting-logo.png": [
         0, 
-        -19930
+        -19912
     ], 
     "../images/treeCollapsed.png": [
         0, 
@@ -391,19 +391,19 @@
     ], 
     "../images/green-bar.png": [
         0, 
-        -15082
+        -15246
     ], 
     "../images/build-superseded.png": [
         0, 
-        -12950
+        -13114
     ], 
     "../images/trash-large.png": [
         0, 
-        -18068
+        -18050
     ], 
     "../images/red-bar.png": [
         0, 
-        -15410
+        -15574
     ], 
     "../images/add.png": [
         0, 
@@ -413,9 +413,13 @@
         0, 
         -328
     ], 
+    "../images/read-only.png": [
+        0, 
+        -9998
+    ], 
     "../images/person-inactive-logo.png": [
         0, 
-        -19502
+        -19484
     ], 
     "../images/edit.png": [
         0, 
@@ -427,11 +431,11 @@
     ], 
     "../images/warning-large.png": [
         0, 
-        -16248
+        -16412
     ], 
     "../images/arrowEnd.png": [
         0, 
-        -14262
+        -14426
     ], 
     "../images/cve.png": [
         0, 
@@ -439,7 +443,7 @@
     ], 
     "../images/merge-proposal-large.png": [
         0, 
-        -17886
+        -17868
     ], 
     "../images/branch.png": [
         0, 
@@ -469,4 +473,4 @@
         0, 
         -1148
     ]
-}
+}
\ No newline at end of file

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
--- lib/canonical/launchpad/icing/style-3-0.css.in	2011-02-14 07:33:54 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css.in	2011-02-23 10:25:23 +0000
@@ -1471,10 +1471,10 @@
    Colors and fonts
 */
 
-h1, h2, h3, 
-table.listing thead, 
-#homepage-stats strong, 
-#application-footer strong, 
+h1, h2, h3,
+table.listing thead,
+#homepage-stats strong,
+#application-footer strong,
 #application-summary strong {
     color: #5a5a5a;
 }
@@ -2204,7 +2204,10 @@
     background-image: url(/@@/ppa-icon-inactive.png); /* sprite-ref: icon-sprites */
     background-repeat: no-repeat;
     }
-
+.source-package-recipe {
+    background-image: url(/@@/source-package-recipe.png); /* sprite-ref: icon-sprites */
+    background-repeat: no-repeat;
+    }
 .bug-status-expand {
     background-image: url(/@@/bug-status-expand.png); /* sprite-ref: icon-sprites */
     background-repeat: no-repeat;

=== modified file 'lib/lp/code/browser/configure.zcml'
--- lib/lp/code/browser/configure.zcml	2011-02-10 04:16:09 +0000
+++ lib/lp/code/browser/configure.zcml	2011-02-23 10:25:23 +0000
@@ -1239,6 +1239,12 @@
             name="+builds"
             template="../templates/sourcepackagerecipe-builds.pt"
             permission="launchpad.View"/>
+        <browser:page
+            for="lp.code.interfaces.sourcepackagerecipe.ISourcePackageRecipe"
+            layer="lp.code.publisher.CodeLayer"
+            class="lp.code.browser.sourcepackagerecipe.SourcePackageRecipeRequestDailyBuildView"
+            name="+request-daily-build"
+            permission="launchpad.Edit"/>
     </facet>
     <facet facet="branches">
         <browser:defaultView

=== modified file 'lib/lp/code/browser/sourcepackagerecipe.py'
--- lib/lp/code/browser/sourcepackagerecipe.py	2011-02-22 09:07:44 +0000
+++ lib/lp/code/browser/sourcepackagerecipe.py	2011-02-23 10:25:23 +0000
@@ -180,12 +180,27 @@
 
     facet = 'branches'
 
-    links = ('request_builds',)
+    links = ('request_builds', 'request_daily_build',)
 
     def request_builds(self):
         """Provide a link for requesting builds of a recipe."""
         return Link('+request-builds', 'Request build(s)', icon='add')
 
+    def request_daily_build(self):
+        """Provide a link for requesting a daily build of a recipe."""
+        recipe = self.context
+        ppa = recipe.daily_build_archive
+        if (ppa is None or not recipe.build_daily or not recipe.is_stale
+                or not recipe.distroseries):
+            show_request_build = False
+        else:
+            has_upload = ppa.checkArchivePermission(recipe.owner)
+            show_request_build = has_upload
+
+        return Link(
+                '+request-daily-build', 'Build now',
+                enabled=show_request_build)
+
 
 class SourcePackageRecipeView(LaunchpadView):
     """Default view of a SourcePackageRecipe."""
@@ -292,6 +307,17 @@
         return builds
 
 
+def new_builds_notification_text(builds):
+    nr_builds = len(builds)
+    if not nr_builds:
+        builds_text = "All requested recipe builds are already queued."
+    elif nr_builds == 1:
+        builds_text = "1 new recipe build has been queued."
+    else:
+        builds_text = "%d new recipe builds have been queued." % nr_builds
+    return builds_text
+
+
 class SourcePackageRecipeRequestBuildsView(LaunchpadFormView):
     """A view for requesting builds of a SourcePackageRecipe."""
 
@@ -341,14 +367,16 @@
         other builds can ne queued and a message be displayed to the caller.
         """
         errors = {}
+        builds = []
         for distroseries in data['distros']:
             try:
-                self.context.requestBuild(
+                build = self.context.requestBuild(
                     data['archive'], self.user, distroseries, manual=True)
+                builds.append(build)
             except BuildAlreadyPending, e:
                 errors['distros'] = ("An identical build is already pending "
                     "for %s." % e.distroseries)
-        return errors
+        return builds, errors
 
 
 class SourcePackageRecipeRequestBuildsHtmlView(
@@ -367,44 +395,120 @@
 
     @action('Request builds', name='request')
     def request_action(self, action, data):
-        errors = self.requestBuild(data)
+        builds, errors = self.requestBuild(data)
         if errors:
             [self.setFieldError(field, message)
                 for (field, message) in errors.items()]
             return
         self.next_url = self.cancel_url
-
-
-class SourcePackageRecipeRequestBuildsAjaxView(
-        SourcePackageRecipeRequestBuildsView):
-    """Supports AJAX form recipe build requests."""
-
-    def _process_error(self, data, errors, reason):
-        """Set up the response and json data to return to the caller."""
-        self.request.response.setStatus(400, reason)
-        self.request.response.setHeader('Content-type', 'application/json')
-        return simplejson.dumps(errors)
-
-    def failure(self, action, data, errors):
-        """Called by the form if validate() finds any errors.
-
-           We simply convert the errors to json and return that data to the
-           caller for display to the user.
-        """
-        return self._process_error(data, self.widget_errors, "Validation")
-
-    @action('Request builds', name='request', failure=failure)
-    def request_action(self, action, data):
-        """User action for requesting a number of builds.
-
-        The failure handler will handle any validation errors. We still need
-        to handle errors which may occur when invoking the business logic.
-        These "expected" errors are ones which result in a predefined message
-        being displayed to the user. If the business method raises an
-        unexpected exception, that will be handled using the form's standard
-        exception processing mechanism (using response code 500).
-        """
-        errors = self.requestBuild(data)
+        self.request.response.addNotification(
+                new_builds_notification_text(builds))
+
+
+class SourcePackageRecipeRequestBuildsAjaxView(
+        SourcePackageRecipeRequestBuildsView):
+    """Supports AJAX form recipe build requests."""
+
+    def _process_error(self, data, errors, reason):
+        """Set up the response and json data to return to the caller."""
+        self.request.response.setStatus(400, reason)
+        self.request.response.setHeader('Content-type', 'application/json')
+        return simplejson.dumps(errors)
+
+    def failure(self, action, data, errors):
+        """Called by the form if validate() finds any errors.
+
+           We simply convert the errors to json and return that data to the
+           caller for display to the user.
+        """
+        return self._process_error(data, self.widget_errors, "Validation")
+
+    @action('Request builds', name='request', failure=failure)
+    def request_action(self, action, data):
+        """User action for requesting a number of builds.
+
+        The failure handler will handle any validation errors. We still need
+        to handle errors which may occur when invoking the business logic.
+        These "expected" errors are ones which result in a predefined message
+        being displayed to the user. If the business method raises an
+        unexpected exception, that will be handled using the form's standard
+        exception processing mechanism (using response code 500).
+        """
+        builds, errors = self.requestBuild(data)
+        # If there are errors we return a json data snippet containing the
+        # errors instead of rendering the form. These errors are processed
+        # by the caller's response handler and displayed to the user.
+        if errors:
+            return self._process_error(data, errors, "Request Build")
+
+    @property
+    def builds(self):
+        return builds_for_recipe(self.context)
+
+
+class SourcePackageRecipeRequestDailyBuildView(LaunchpadFormView):
+    """Supports requests to perform a daily build for a recipe.
+
+    Renders the recipe builds table so that the recipe index page can be
+    updated with the new build records.
+
+    This view works for both ajax and html form requests.
+    """
+
+    # Attributes for the html version
+    page_title = "Build now"
+
+    class schema(Interface):
+        """Schema for requesting a build."""
+
+    @action('Build now', name='build')
+    def build_action(self, action, data):
+        recipe = self.context
+        builds = recipe.performDailyBuild()
+        if self.request.is_ajax:
+            template = ViewPageTemplateFile(
+                    "../templates/sourcepackagerecipe-builds.pt")
+            return template(self)
+        else:
+            self.next_url = canonical_url(recipe)
+            self.request.response.addNotification(
+                    new_builds_notification_text(builds))
+
+    @property
+    def builds(self):
+        return builds_for_recipe(self.context)
+
+
+class SourcePackageRecipeRequestBuildsAjaxView(
+        SourcePackageRecipeRequestBuildsView):
+    """Supports AJAX form recipe build requests."""
+
+    def _process_error(self, data, errors, reason):
+        """Set up the response and json data to return to the caller."""
+        self.request.response.setStatus(400, reason)
+        self.request.response.setHeader('Content-type', 'application/json')
+        return simplejson.dumps(errors)
+
+    def failure(self, action, data, errors):
+        """Called by the form if validate() finds any errors.
+
+           We simply convert the errors to json and return that data to the
+           caller for display to the user.
+        """
+        return self._process_error(data, self.widget_errors, "Validation")
+
+    @action('Request builds', name='request', failure=failure)
+    def request_action(self, action, data):
+        """User action for requesting a number of builds.
+
+        The failure handler will handle any validation errors. We still need
+        to handle errors which may occur when invoking the business logic.
+        These "expected" errors are ones which result in a predefined message
+        being displayed to the user. If the business method raises an
+        unexpected exception, that will be handled using the form's standard
+        exception processing mechanism (using response code 500).
+        """
+        builds, errors = self.requestBuild(data)
         # If there are errors we return a json data snippet containing the
         # errors instead of rendering the form. These errors are processed
         # by the caller's response handler and displayed to the user.

=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2011-02-21 20:55:00 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py	2011-02-23 10:25:23 +0000
@@ -26,6 +26,7 @@
 from canonical.launchpad.testing.pages import (
     extract_text,
     find_main_content,
+    find_tag_by_id,
     find_tags_by_class,
     get_feedback_messages,
     get_radio_button_text_for_field,
@@ -1227,6 +1228,88 @@
         self.assertEqual(
             [build1, build2, build3, build4, build5], view.builds)
 
+    def test_request_daily_builds_button_stale(self):
+        # Recipes that are stale and are built daily have a build now link
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=self.ppa,
+            is_stale=True, build_daily=True)
+        browser = self.getViewBrowser(recipe)
+        build_button = find_tag_by_id(browser.contents, 'field.actions.build')
+        self.assertIsNot(None, build_button)
+
+    def test_request_daily_builds_button_not_stale(self):
+        # Recipes that are not stale do not have a build now link
+        login(ANONYMOUS)
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=self.ppa,
+            is_stale=False, build_daily=True)
+        browser = self.getViewBrowser(recipe)
+        build_button = find_tag_by_id(browser.contents, 'field.actions.build')
+        self.assertIs(None, build_button)
+
+    def test_request_daily_builds_button_not_daily(self):
+        # Recipes that are not built daily do not have a build now link
+        login(ANONYMOUS)
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=self.ppa,
+            is_stale=True, build_daily=False)
+        browser = self.getViewBrowser(recipe)
+        build_button = find_tag_by_id(browser.contents, 'field.actions.build')
+        self.assertIs(None, build_button)
+
+    def test_request_daily_builds_button_no_daily_ppa(self):
+        # Recipes that have no daily build ppa do not have a build now link
+        login(ANONYMOUS)
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, is_stale=True, build_daily=True)
+        naked_recipe = removeSecurityProxy(recipe)
+        naked_recipe.daily_build_archive = None
+        browser = self.getViewBrowser(recipe)
+        build_button = find_tag_by_id(browser.contents, 'field.actions.build')
+        self.assertIs(None, build_button)
+
+    def test_request_daily_builds_button_ppa_with_no_permissions(self):
+        # Recipes that have a daily build ppa without upload permissions
+        # do not have a build now link
+        login(ANONYMOUS)
+        distroseries = self.factory.makeSourcePackageRecipeDistroseries()
+        person = self.factory.makePerson()
+        daily_build_archive = self.factory.makeArchive(
+                distribution=distroseries.distribution, owner=person)
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=daily_build_archive,
+            is_stale=True, build_daily=True)
+        browser = self.getViewBrowser(recipe)
+        build_button = find_tag_by_id(browser.contents, 'field.actions.build')
+        self.assertIs(None, build_button)
+
+    def test_request_daily_builds_ajax_link_not_rendered(self):
+        # The Build now link should not be rendered without javascript.
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=self.ppa,
+            is_stale=True, build_daily=True)
+        browser = self.getViewBrowser(recipe)
+        build_link = find_tag_by_id(browser.contents, 'request-daily-builds')
+        self.assertIs(None, build_link)
+
+    def test_request_daily_builds_action(self):
+        # Daily builds should be triggered when requested.
+        recipe = self.factory.makeSourcePackageRecipe(
+            owner=self.chef, daily_build_archive=self.ppa,
+            is_stale=True, build_daily=True)
+        browser = self.getViewBrowser(recipe)
+        browser.getControl('Build now').click()
+        login(ANONYMOUS)
+        builds = recipe.getPendingBuilds()
+        build_distros = [
+            build.distroseries.displayname for build in builds]
+        build_distros.sort()
+        # Our recipe has a Warty distroseries
+        self.assertEqual(['Warty'], build_distros)
+        self.assertEqual(
+            set([2505]),
+            set(build.buildqueue_record.lastscore for build in builds))
+
     def test_request_builds_page(self):
         """Ensure the +request-builds page is sane."""
         recipe = self.makeRecipe()

=== modified file 'lib/lp/code/interfaces/sourcepackagerecipe.py'
--- lib/lp/code/interfaces/sourcepackagerecipe.py	2011-02-18 03:39:25 +0000
+++ lib/lp/code/interfaces/sourcepackagerecipe.py	2011-02-23 10:25:23 +0000
@@ -136,6 +136,10 @@
             able to upload to the archive.
         """
 
+    @export_write_operation()
+    def performDailyBuild():
+        """Perform a build into the daily build archive."""
+
 
 class ISourcePackageRecipeEdit(Interface):
     """ISourcePackageRecipe methods that require launchpad.Edit permission."""

=== modified file 'lib/lp/code/javascript/requestbuild_overlay.js'
--- lib/lp/code/javascript/requestbuild_overlay.js	2011-02-18 01:06:19 +0000
+++ lib/lp/code/javascript/requestbuild_overlay.js	2011-02-23 10:25:23 +0000
@@ -12,7 +12,8 @@
 
 var lp_client;
 var request_build_overlay = null;
-var response_handler;
+var request_build_response_handler;
+var request_daily_build_response_handler;
 
 function set_up_lp_client() {
     if (lp_client === undefined) {
@@ -55,7 +56,7 @@
     }
 };
 
-namespace.connect_requestbuild = function() {
+namespace.connect_requestbuilds = function() {
 
     var request_build_handle = Y.one('#request-builds');
     request_build_handle.addClass('js-action');
@@ -80,26 +81,102 @@
             request_build_overlay.render();
         }
         request_build_overlay.clearError();
-        var temp_spinner = [
+        var loading_spinner = [
             '<div id="temp-spinner">',
             '<img src="/@@/spinner"/>Loading...',
             '</div>'].join('');
-        request_build_overlay.form_node.set("innerHTML", temp_spinner);
+        request_build_overlay.form_node.set("innerHTML", loading_spinner);
         request_build_overlay.loadFormContentAndRender('+builds/++form++');
         request_build_overlay.show();
     });
 
     // Wire up the processing hooks
-    response_handler = new RequestResponseHandler();
-    response_handler.clearProgressUI = function() {
+    request_build_response_handler = new RequestResponseHandler();
+    request_build_response_handler.clearProgressUI = function() {
         destroy_temporary_spinner();
     };
-    response_handler.showError = function(error) {
+    request_build_response_handler.showError = function(error) {
         request_build_overlay.showError(error);
         Y.log(error);
     };
 };
 
+var NO_BUILDS_MESSAGE = "All requested recipe builds are already queued.";
+var ONE_BUILD_MESSAGE = "1 new recipe build has been queued.";
+var MANY_BUILDS_MESSAGE = "{nr_new} new recipe builds have been queued.";
+
+namespace.connect_requestdailybuild = function() {
+
+    var request_daily_build_handle = Y.one('#request-daily-build');
+    request_daily_build_handle.on('click', function(e) {
+        e.preventDefault();
+
+        create_temporary_spinner(
+                "Requesting build...", request_daily_build_handle);
+        request_daily_build_handle.addClass("unseen");
+
+        var base_url = LP.client.cache.context.web_link;
+        var submit_url = base_url+"/+request-daily-build";
+        var current_builds = harvest_current_build_records();
+
+        var qs = LP.client.append_qs('', 'field.actions.build', 'Build now');
+        var y_config = {
+            method: "POST",
+            headers: {'Accept': 'application/xhtml'},
+            on: {
+                failure: request_daily_build_response_handler.getErrorHandler(
+                    function(handler, id, response) {
+                        request_daily_build_handle.removeClass("unseen");
+                        var server_error = 'Server error, ' +
+                                           'please contact an administrator.';
+                        handler.showError(server_error);
+                    }),
+                success:
+                    request_daily_build_response_handler.getSuccessHandler(
+                    function(handler, id, response) {
+                        var nr_new = display_build_records(
+                                response.responseText, current_builds);
+                        var new_builds_message;
+                        switch (nr_new) {
+                            case 0:
+                                new_builds_message = NO_BUILDS_MESSAGE;
+                                break;
+                            case 1:
+                                new_builds_message = ONE_BUILD_MESSAGE;
+                                break;
+                            default:
+                                new_builds_message =
+                                        Y.Lang.substitute(
+                                                MANY_BUILDS_MESSAGE,
+                                                {nr_new: nr_new});
+                        }
+                        var build_message_node = Y.Node.create([
+                            '<div id="new-builds-info" class="build-informational">',
+                            new_builds_message,
+                            '</div>'].join(''));
+                        request_daily_build_handle.insert(
+                                build_message_node,
+                                request_daily_build_handle);
+                        Y.later(20000, build_message_node, 'hide', true);
+                    }
+                  )
+            },
+            data: qs
+        };
+        Y.io(submit_url, y_config);
+    });
+
+    // Wire up the processing hooks
+    request_daily_build_response_handler = new RequestResponseHandler();
+    request_daily_build_response_handler.clearProgressUI = function() {
+        destroy_temporary_spinner();
+    };
+    request_daily_build_response_handler.showError = function(error) {
+        alert(error);
+        Y.log(error);
+    };
+};
+
 /*
  * A function to return the current build records as displayed on the page
  */
@@ -118,14 +195,34 @@
 }
 
 /*
+ * Render build records and flash the new ones
+ */
+function display_build_records(build_records_markup, current_builds) {
+    var target = Y.one('#builds-target');
+    target.set('innerHTML', build_records_markup);
+    var new_builds = harvest_current_build_records();
+    var nr_new_builds = 0;
+    Y.Array.each(new_builds, function(row_id) {
+        if( current_builds.indexOf(row_id)>=0 )
+            return;
+        nr_new_builds += 1;
+        var row = Y.one('#'+row_id);
+        var anim = Y.lazr.anim.green_flash({node: row});
+        anim.run();
+    });
+    return nr_new_builds;
+}
+
+/*
  * Perform any client side validation
  * Return: true if data is valid
  */
 function validate(data) {
     var distros = data['field.distros']
     if (Y.Object.size(distros) == 0) {
-        response_handler.showError("You need to specify at least one " +
-                "distro series for which to build.");
+        request_build_response_handler.showError(
+                "You need to specify at least one distro series for " +
+                "which to build.");
         return false;
     }
     return true;
@@ -137,7 +234,9 @@
 function do_request_builds(data) {
     if (!validate(data))
         return;
-    create_temporary_spinner();
+    var spinner_location = Y.one('.yui3-lazr-formoverlay-actions');
+    create_temporary_spinner("Requesting builds...", spinner_location);
+
     var base_url = LP.client.cache.context.web_link;
     var submit_url = base_url+"/+builds";
     var current_builds = harvest_current_build_records();
@@ -145,14 +244,14 @@
         method: "POST",
         headers: {'Accept': 'application/json; application/xhtml'},
         on: {
-            failure: response_handler.getErrorHandler(
+            failure: request_build_response_handler.getErrorHandler(
                 function(handler, id, response) {
                     if( response.status >= 500 ) {
                         // There's some error content we need to display.
                         request_build_overlay.set(
                                 'form_content', response.responseText);
                         request_build_overlay.get("form_submit_button")
-                                .setStyle('display', 'none');
+                                .addClass('unseen');
                         request_build_overlay.renderUI();
                         //We want to force the form to be re-created
                         request_build_overlay = null;
@@ -164,19 +263,11 @@
                         errors.push(error_info[field_name]);
                     handler.showError(errors);
                 }),
-            success: response_handler.getSuccessHandler(
+            success: request_build_response_handler.getSuccessHandler(
                 function(handler, id, response) {
                     request_build_overlay.hide();
-                    var target = Y.one('#builds-target');
-                    target.set('innerHTML', response.responseText);
-                    var new_builds = harvest_current_build_records();
-                    Y.Array.each(new_builds, function(row_id) {
-                        if (current_builds.indexOf(row_id)>=0)
-                            return;
-                        var row = Y.one('#'+row_id);
-                        var anim = Y.lazr.anim.green_flash({node: row});
-                        anim.run();
-                    });
+                    display_build_records(
+                            response.responseText, current_builds)
                 })
         },
         form: {
@@ -190,14 +281,14 @@
 /*
  * Show the temporary "Requesting..." text
  */
-function create_temporary_spinner() {
+function create_temporary_spinner(text, node) {
     // Add the temp "Requesting build..." text
     var temp_spinner = Y.Node.create([
         '<div id="temp-spinner">',
-        '<img src="/@@/spinner"/>Requesting build...',
+        '<img src="/@@/spinner"/>',
+        text,
         '</div>'].join(''));
-    var request_build_handle = Y.one('.yui3-lazr-formoverlay-actions');
-    request_build_handle.insert(temp_spinner, request_build_handle);
+    node.insert(temp_spinner, node);
 }
 
 /*

=== modified file 'lib/lp/code/model/sourcepackagerecipe.py'
--- lib/lp/code/model/sourcepackagerecipe.py	2011-02-18 23:51:57 +0000
+++ lib/lp/code/model/sourcepackagerecipe.py	2011-02-23 10:25:23 +0000
@@ -281,6 +281,20 @@
             queue_record.manualScore(queue_record.lastscore + 100)
         return build
 
+    def performDailyBuild(self):
+        """See `ISourcePackageRecipe`."""
+        builds = []
+        self.is_stale = False
+        for distroseries in self.distroseries:
+            try:
+                build = self.requestBuild(
+                    self.daily_build_archive, self.owner,
+                    distroseries, PackagePublishingPocket.RELEASE)
+                builds.append(build)
+            except BuildAlreadyPending:
+                continue
+        return builds
+
     def getBuilds(self):
         """See `ISourcePackageRecipe`."""
         where_clause = BuildFarmJob.status != BuildStatus.NEEDSBUILD

=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt	2011-02-22 09:07:44 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt	2011-02-23 10:25:23 +0000
@@ -16,6 +16,18 @@
       font-family: "UbuntuBeta Mono","Ubuntu Mono",monospace;
       margin-top: -15px;
     }
+    .build-informational {
+        background: #d4e8ff url('/+icing/blue-fade-to-grey');
+        border: solid #666;
+        border-width: 1px 2px 2px 1px;
+        color: black;
+        padding: 5px 5px 5px 5px;
+        margin-right: 40px
+        }
+    .build-informational::before {
+        padding-right: 5px;
+        content: url('/@@/info');
+        }
   </style>
 </metal:block>
 
@@ -60,6 +72,23 @@
               </a>
             </dt>
             <dd tal:content="structure view/daily_build_widget"/>
+            <dd
+              tal:define="link context/menu:context/request_daily_build"
+              tal:condition="link/enabled"
+              >
+              <noscript>
+                <form action="+request-daily-build"
+                      method="post"
+                      id="request-daily-build-form">
+                    <input type="submit" name="field.actions.build"
+                        id="field.actions.build" value="Build now" />
+                </form>
+              </noscript>
+              <a id="request-daily-build"
+                 class="sprite source-package-recipe js-action unseen"
+                 tal:attributes="href link/url"
+                 tal:content="link/text"/>
+            </dd>
           </dl>
 
           <dl id="owner">
@@ -116,11 +145,16 @@
         if(Y.UA.ie) {
             return;
         }
-
         Y.on('load', function() {
             var logged_in = LP.client.links['me'] !== undefined;
             if (logged_in) {
-                Y.lp.code.requestbuild_overlay.connect_requestbuild();
+                build_now_link = Y.one('#request-daily-build');
+                if( build_now_link != null ) {
+                  build_now_link.removeClass('unseen');
+                  Y.lp.code.requestbuild_overlay.connect_requestdailybuild();
+                }
+                Y.lp.code.requestbuild_overlay.connect_requestbuilds();
+
             }
         }, window);
       });"

=== modified file 'lib/lp/code/windmill/tests/test_recipe_request_build.py'
--- lib/lp/code/windmill/tests/test_recipe_request_build.py	2011-02-18 01:06:19 +0000
+++ lib/lp/code/windmill/tests/test_recipe_request_build.py	2011-02-23 10:25:23 +0000
@@ -13,13 +13,12 @@
 from lp.testing.windmill.constants import (
     FOR_ELEMENT,
     PAGE_LOAD,
-    SLEEP,
     )
 from lp.testing.windmill.lpuser import login_person
 from lp.app.browser.tales import PPAFormatterAPI
 from lp.code.windmill.testing import CodeWindmillLayer
 from lp.soyuz.model.processor import ProcessorFamily
-from lp.testing import WindmillTestCase
+from lp.testing import WindmillTestCase, quote_jquery_expression
 
 
 class TestRecipeBuild(WindmillTestCase):
@@ -50,7 +49,7 @@
             owner=self.chef, distroseries=self.squirrel, name=u'cake_recipe',
             description=u'This recipe builds a foo for disto bar, with my'
             ' Secret Squirrel changes.', branches=[cake_branch],
-            daily_build_archive=self.ppa)
+            daily_build_archive=self.ppa, build_daily=True, is_stale=True)
         transaction.commit()
         login_person(self.chef, "[e-mail]", "test", self.client)
 
@@ -74,8 +73,8 @@
 
         # Ensure it shows up.
         client.waits.forElement(
-            xpath = (u'//tr[contains(@class, "package-build")]/td[4]'
-                     '/a[@href="%s"]') % PPAFormatterAPI(self.ppa).url(),
+            jquery=u"('tr.package-build a[href$=\"%s\"]')"
+            % quote_jquery_expression(PPAFormatterAPI(self.ppa).url()),
             timeout=FOR_ELEMENT)
 
         # And try the same one again.
@@ -85,12 +84,27 @@
 
         # And check that there's an error.
         client.waits.forElement(
-            xpath = (
-                u'//div[contains(@class, "yui3-lazr-formoverlay-errors")]'
-                '/ul/li'), timeout=FOR_ELEMENT)
-        client.asserts.assertText(
-            xpath = (
-                u'//div[contains(@class, "yui3-lazr-formoverlay-errors")]'
-                '/ul/li'),
+            jquery=u"('div.yui3-lazr-formoverlay-errors ul li')",
+            timeout=FOR_ELEMENT)
+
+        client.asserts.assertTextIn(
+            jquery=u"('div.yui3-lazr-formoverlay-errors ul li')[0]",
             validator=u'An identical build is already pending for %s %s.'
                         % (self.ppa.distribution.name, self.squirrel.name))
+
+    def test_recipe_daily_build_request(self):
+        """Request a recipe build."""
+
+        client = self.client
+        client.open(url=canonical_url(self.recipe))
+        client.waits.forElement(
+            id=u'request-daily-build', timeout=PAGE_LOAD)
+
+        # Request a daily build.
+        client.click(id=u'request-daily-build')
+
+        # Ensure it shows up.
+        client.waits.forElement(
+            jquery=u"('tr.package-build a[href$=\"%s\"]')"
+            % quote_jquery_expression(PPAFormatterAPI(self.ppa).url()),
+            timeout=FOR_ELEMENT)

=== modified file 'lib/lp/testing/__init__.py'
--- lib/lp/testing/__init__.py	2011-02-11 00:25:51 +0000
+++ lib/lp/testing/__init__.py	2011-02-23 10:25:23 +0000
@@ -28,6 +28,7 @@
     'normalize_whitespace',
     'oauth_access_token_for',
     'person_logged_in',
+    'quote_jquery_expression'
     'record_statements',
     'run_with_login',
     'run_with_storm_debug',
@@ -790,6 +791,12 @@
         return client, obj_url
 
 
+def quote_jquery_expression(expression):
+    """jquery requires meta chars used in literals escaped with \\"""
+    return re.sub(
+        "([#!$%&()+,./:;?@~|^{}\\[\\]`*\\\'\\\"])", r"\\\\\1", expression)
+
+
 class YUIUnitTestCase(WindmillTestCase):
 
     layer = None