Launchpad itself

Merge lp:~wallyworld/launchpad/private-dupe-bug-warning4 into lp:launchpad

private-dupe-bug-warning4
Merge into devel

Proposed by Ian Booth on 2012-07-30

Status:

Merged

Approved by:

Ian Booth on 2012-07-31

Approved revision:

no longer in the source branch.

Merged at revision:

15719

Proposed branch:

lp:~wallyworld/launchpad/private-dupe-bug-warning4

Merge into:

lp:launchpad

Prerequisite:

lp:~wallyworld/launchpad/private-dupe-bug-warning3

Diff against target:

0 lines

To merge this branch:

bzr merge lp:~wallyworld/launchpad/private-dupe-bug-warning4

Related bugs:

Bug #190635: Cannot tell that you chose the right bug when marking as a duplicate	Low	Fix Released
Bug #767084: "Mark as duplicate" popup gives an unhelpful error when attempted to dupe against a dupe	Low	Fix Released
Bug #943497: warn when you are going to mark a public bug as a duplicate of a private one	High	Fix Released
Bug #1023425: Duplicate error "not a valid bug number or nickname" when nicknames are defunct	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ian Booth (community)			Approve on 2012-07-31
Review via email: mp+117364@code.launchpad.net

Commit message

Improve the usability of the bug dupe popup and first stage refactor to make it more like a bug picker so it can be resued.

Description of the change

== Implementation ==

A largely mechanical change to:
- generalise some class/variable/module names to "bug_picker" instead of "duplicate"
(first step to making a generic bug picker rather than just a dupe picker)
- improve picker behaviour as per Curtis' suggestions from previous branch

== Pre-Implementation ==

Curtis

== Tests ==

Update existing yui tests.

== Lint ==

Linting changed files:
  lib/canonical/launchpad/icing/css/components/bug_picker.css
  lib/lp/app/javascript/formoverlay/formoverlay.js
  lib/lp/app/javascript/formoverlay/assets/formoverlay-core.css
  lib/lp/app/javascript/overlay/overlay.js
  lib/lp/bugs/javascript/bug_picker.js
  lib/lp/bugs/javascript/bugtask_index.js
  lib/lp/bugs/javascript/tests/test_duplicates.html
  lib/lp/bugs/javascript/tests/test_duplicates.js
  lib/lp/bugs/templates/bug-portlet-actions.pt

Revision history for this message

Ian Booth (wallyworld) wrote on 2012-07-31:

As discussed, with Curtis, changes a largely mechanical and confined to bug picker javascript from previous branch, so self approve. We want this to land.

review: Approve