Merge lp:~wallyworld/launchpad/person-vocab-1006244 into lp:launchpad
Proposed by
Ian Booth
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 15346 | ||||||||
Proposed branch: | lp:~wallyworld/launchpad/person-vocab-1006244 | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
62 lines (+19/-0) 2 files modified
lib/lp/registry/tests/test_person_vocabularies.py (+13/-0) lib/lp/registry/vocabularies.py (+6/-0) |
||||||||
To merge this branch: | bzr merge lp:~wallyworld/launchpad/person-vocab-1006244 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+108124@code.launchpad.net |
Commit message
Add extra account check to person vocab search so that inactive people are not included
Description of the change
== Implementation ==
This branch filters people with inactive accounts from person vocab results.
Add a new left join to Account table main person query and filter result on active accounts or teams.
Query was checked on dogfood and its all good.
== Tests ==
Add new test to test_person_
- test_inactive_
Run existing vocab tests to check that other queries still work.
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
To post a comment you must log in.
Thank you.