Merge lp:~wallyworld/launchpad/person-related-artifact-counts-206917 into lp:launchpad

[Ian Booth]

Replace bug/question/blueprint counts with icons on the person related software page; remove the related project info from the page.

== Implementation ==

Two issues are addressed to reduce the SQL needed to load the person related software page:
- remove the related projects table from the related software page; there is now a link on the person index page to get to it and there's also still the link on the related projects page
- the bug/question/blueprint links are rendered as icons rather than counts (which are somewhat meaningless)

See the 2 linked bugs for justification.

The above almost halves the query count to populate the related software page.

== Demo and QA ==

Screenshots of selected new related software pages:

http://people.canonical.com/~ianb/related-software.png
http://people.canonical.com/~ianb/uploaded-packages.png

== Tests ==

Existing tests were tweaked to account for the new page content.

== Lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/person.py
  lib/lp/registry/browser/tests/test_person.py
  lib/lp/registry/stories/person/xx-person-projects.txt
  lib/lp/registry/templates/person-index.pt
  lib/lp/registry/templates/person-macros.pt
  lib/lp/registry/templates/person-related-projects.pt
  lib/lp/registry/templates/person-related-software.pt
  lib/lp/soyuz/stories/soyuz/xx-person-packages.txt

[Curtis Hovey (sinzui)]

Remove the bug, question, and blueprint columns. They are not informing me of anything. The project's front page already shows the latest of these if the project uses them. Reading the doctest, for this page, we can see how massively useless it is. What people really want to know is /how/ the user is related to the project...maintainer, driver, bug supervisor which I just found bug 996599, then marked 2 more as dupes.

I am not sure I agree with the removal of "related projects" from "software" I would have tried to rename the section, which is maybe why I never fixed this when I ran the lp-registry team. By separating the two, you also fix another bug. I suppose this is the right thing to do given that there is a request to show recipe data too. as for the projects themselves, it would could one day have a companion of project the team the user owns, but does not participate in.

I do not see the addition of the link to related-projects to person-index.pt which makes the links. I see a rename in configure.zcml, but that does not change the text users see. There is a verbal disconnect to what the user is doing/or has bookmarked and what they see...the link name should be the same as the breadcrumb/title so I expect a link to "Related projects". How do I get to my related package pages, only from this related-* menu on these pages? Maybe we can compromise and rename "Related software and packages" to "Related projects and packages"

review: Needs Information (code)

[Ian Booth (wallyworld)]

I have removed the bug, questions, blueprints columns for packages and projects.

For projects, I have added Is Owner, Is Driver, and Is Bug Supervisor columns to show why that project is included on the view. This addresses bug 996599.

http://people.canonical.com/~ianb/new-related-projects.png

I have kept the projects view separate and renamed "Related Software" to "Related Packages". This is partly because the individual views and links are called "Maintained Packages", "Uploaded Packages" etc so, to me at least, the terminology is consistent. The person and also team index pages also have the extra link to the Related Projects page.

[Curtis Hovey (sinzui)]

You din't have to do the extra work, but I am sure many will appreciate it. Thank you.

review: Approve (code)