Merge lp:~wallyworld/launchpad/optional-extended-choice-popup-933743 into lp:launchpad
Proposed by
Ian Booth
Status: | Merged |
---|---|
Approved by: | Ian Booth |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14828 |
Proposed branch: | lp:~wallyworld/launchpad/optional-extended-choice-popup-933743 |
Merge into: | lp:launchpad |
Prerequisite: | lp:~wallyworld/launchpad/choice-popup-descriptions-932424 |
Diff against target: |
102 lines (+22/-10) 3 files modified
lib/lp/app/browser/lazrjs.py (+8/-5) lib/lp/app/widgets/tests/test_itemswidgets.py (+12/-1) lib/lp/bugs/browser/bugtask.py (+2/-4) |
To merge this branch: | bzr merge lp:~wallyworld/launchpad/optional-extended-choice-popup-933743 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+93518@code.launchpad.net |
Commit message
[r=stevenk][bug=933743] Add configuration option to enum popup widget to control whether item descriptions are displayed. Default is no.
Description of the change
== Implementation ==
We want to only show the item description in the enum popup widget when asked for.
Add include_description parameter to lazrjs vocabulary_
== Tests ==
Add new test to ensure description is only there when asked for.
== Lint ==
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
To post a comment you must log in.
Looks excellent, thank you. And I always approve of lint fixes.