Merge lp:~wallyworld/launchpad/link-checker-oops into lp:launchpad
Proposed by
Ian Booth
on 2010-11-11
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Tim Penhey on 2010-11-12 | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11913 | ||||
| Proposed branch: | lp:~wallyworld/launchpad/link-checker-oops | ||||
| Merge into: | lp:launchpad | ||||
| To merge this branch: | bzr merge lp:~wallyworld/launchpad/link-checker-oops | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | 2010-11-11 | Approve on 2010-11-12 | |
|
Review via email:
|
|||
Commit Message
[r=thumper]
Description of the Change
=Summary =
See bug 671390. On oops is generated if +check-links is invoked directly.
= Implementatiom =
The server side code assumed the client javascript would only pass valid data, and this is true. However, if the +check-links is invoked directly, then no data is present in the request and a check is needed for this.
= Tests =
Added new test case to test_linkchecker.
bin/test -vvt test_linkchecker
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
To post a comment you must log in.
review:
Approve
